Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Polar Padding Logic #28

Merged
merged 2 commits into from
Dec 7, 2021
Merged

Refactor Polar Padding Logic #28

merged 2 commits into from
Dec 7, 2021

Conversation

cmpark0126
Copy link
Owner

Issue

  • 기존 padding을 만들때는 렌더링 과정에서 어색한 부분이 존재 (육안으로 확인됨)
  • 원인은 polar chart의 각 area들의 반지름이 달라 발생하는 문제로 파악됨
  • 이에 반지름 별로 adaptive하게 패딩을 조정하여 어색한 부분을 제거하는 작업 진행

Details

@cmpark0126 cmpark0126 changed the base branch from master to polar December 7, 2021 19:38
@cmpark0126 cmpark0126 merged commit a213aa7 into polar Dec 7, 2021
cmpark0126 added a commit that referenced this pull request Dec 14, 2021
* refactor(polar): create inner radius per area

* fix(polar): follow linter
cmpark0126 added a commit that referenced this pull request Dec 21, 2021
* refactor(polar): create inner radius per area

* fix(polar): follow linter
cmpark0126 added a commit that referenced this pull request Dec 22, 2021
* refactor(polar): create inner radius per area

* fix(polar): follow linter
cmpark0126 added a commit that referenced this pull request Jan 5, 2022
* refactor(polar): create inner radius per area

* fix(polar): follow linter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant