feat: read enableChangesStream when sync changes stream #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
killagu
force-pushed
the
feat/dynamic_config
branch
from
3070055 to
a72920f
Compare
killagu
force-pushed
the
feat/dynamic_config
branch
from
a72920f to
fa1ab05
Compare
Codecov Report
@@ Coverage Diff @@
## main #250 +/- ##
=======================================
Coverage 97.16% 97.16%
=======================================
Files 119 119
Lines 3632 3633 +1
Branches 320 321 +1
=======================================
+ Hits 3529 3530 +1
Misses 103 103
Continue to review full report at Codecov.
|
elrrrrrrr
approved these changes
Jun 24, 2022
|
|
fengmk2
reviewed
Jun 25, 2022
| @@ -62,7 +62,8 @@ export class ChangesStreamService extends AbstractService { | |||
| this.logger.warn('[ChangesStreamService.executeTask:firstSeq] GET %s status: %s, data: %j, since: %s', | |||
| changesStreamRegistry, status, data, since); | |||
| } | |||
| while (since) { | |||
| // allow disable changesStream dynamic | |||
| while (since && this.config.cnpmcore.enableChangesStream) { | |||
There was a problem hiding this comment.
配置了 enableChangesStream 为 false 的，都不会调用 executeTask
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.