Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate CI/CD pipeline #2

Closed
jkwan2011 opened this issue Jun 7, 2023 · 1 comment · Fixed by #25
Closed

Investigate CI/CD pipeline #2

jkwan2011 opened this issue Jun 7, 2023 · 1 comment · Fixed by #25
Labels
rules-engine Issues related to the Python rules engine

Comments

@jkwan2011
Copy link
Collaborator

Investigate:

  • Linting/static analysis tools
  • CI tests
@alanisaac alanisaac added the rules-engine Issues related to the Python rules engine label Jun 14, 2023
@alanisaac alanisaac mentioned this issue Jun 21, 2023
Merged
@alanisaac
Copy link
Collaborator

Any strong opinions on what static analysis tools we should use? Some suggestions from tools I've used:

Any and all tools above run through ruff if possible.

@alanisaac alanisaac mentioned this issue Jun 21, 2023
Merged
@thadk thadk closed this as completed in #25 Jun 22, 2023
thadk added a commit that referenced this issue Mar 13, 2024
@thadk
WIP form #2
f097b77
thadk added a commit that referenced this issue Mar 20, 2024
@thadk
WIP form #2
ee739ea
Leopardfoot added a commit that referenced this issue Mar 20, 2024
@thadk @plocket
@clayton-schneider @teykamp @jkoren @Leopardfoot @hectorbenitez19 @mrmchughes @camdenblatchly
Add home info conform (#150)
627ec5e 
* Did a first draft of zod+conform v1

Must move action to a route for submit to work.

Co-authored-by: plocket <plocket@users.noreply.github.com>
Co-authored-by: Clayton Schneider <clayton-schneider@users.noreply.github.com>
Co-authored-by: teykamp <teykamp@users.noreply.github.com>

* Route for input1 and Conform on HomeInformation

Co-authored-by: plocket <plocket@users.noreply.github.com>
Co-authored-by: Clayton Schneider <clayton-schneider@users.noreply.github.com>
Co-authored-by: teykamp <thomas@eykamp.com>
Co-authored-by: Jeff Korenstein <jkoren@users.noreply.github.com>
Co-authored-by: Leopardfoot <Leopardfoot@users.noreply.github.com>
Co-authored-by: hectorbenitez19 <hectorbenitez19@users.noreply.github.com>

* Client side conform form validation

Co-authored-by: Clayton Schneider <clayton-schneider@users.noreply.github.com>
Co-authored-by: hectorbenitez19 <hectorbenitez19@users.noreply.github.com>
Co-authored-by: Michael Hughes <mrmchughes@users.noreply.github.com>
Co-authored-by: Leopardfoot <Leopardfoot@users.noreply.github.com>

* Server side checking/handling

Co-authored-by: Clayton Schneider <clayton-schneider@users.noreply.github.com>
Co-authored-by: plocket <plocket@users.noreply.github.com>
Co-authored-by: Leopardfoot <Leopardfoot@users.noreply.github.com>

* consolidated form to single page

Co-authored-by: Clayton Schneider <clayton-schneider@users.noreply.github.com>
Co-authored-by: Michael Hughes <mrmchughes@users.noreply.github.com>
Co-authored-by: Leopardfoot <Leopardfoot@users.noreply.github.com>
Co-authored-by: plocket <plocket@users.noreply.github.com>

* WIP form #2

* Finished HomeInformation on single, CurrentHeatingSystem WIP

Co-authored-by: plocket <plocket@users.noreply.github.com>
Co-authored-by: Clayton Schneider <clayton-schneider@users.noreply.github.com>
Co-authored-by: Leopardfoot <Leopardfoot@users.noreply.github.com>
Co-authored-by: Camden Blatchly <camdenblatchly@users.noreply.github.com>

---------

Co-authored-by: plocket <plocket@users.noreply.github.com>
Co-authored-by: Clayton Schneider <clayton-schneider@users.noreply.github.com>
Co-authored-by: teykamp <teykamp@users.noreply.github.com>
Co-authored-by: teykamp <thomas@eykamp.com>
Co-authored-by: Jeff Korenstein <jkoren@users.noreply.github.com>
Co-authored-by: Leopardfoot <Leopardfoot@users.noreply.github.com>
Co-authored-by: hectorbenitez19 <hectorbenitez19@users.noreply.github.com>
Co-authored-by: Michael Hughes <mrmchughes@users.noreply.github.com>
Co-authored-by: Camden Blatchly <camdenblatchly@users.noreply.github.com>
AdamFinkle referenced this issue in AdamFinkle/home-energy-analysis-tool May 22, 2024
@thadk @plocket
@clayton-schneider @teykamp @jkoren @Leopardfoot @hectorbenitez19 @mrmchughes @camdenblatchly
Add home info conform (codeforboston#150)
8791631 
* Did a first draft of zod+conform v1

Must move action to a route for submit to work.

Co-authored-by: plocket <plocket@users.noreply.github.com>
Co-authored-by: Clayton Schneider <clayton-schneider@users.noreply.github.com>
Co-authored-by: teykamp <teykamp@users.noreply.github.com>

* Route for input1 and Conform on HomeInformation

Co-authored-by: plocket <plocket@users.noreply.github.com>
Co-authored-by: Clayton Schneider <clayton-schneider@users.noreply.github.com>
Co-authored-by: teykamp <thomas@eykamp.com>
Co-authored-by: Jeff Korenstein <jkoren@users.noreply.github.com>
Co-authored-by: Leopardfoot <Leopardfoot@users.noreply.github.com>
Co-authored-by: hectorbenitez19 <hectorbenitez19@users.noreply.github.com>

* Client side conform form validation

Co-authored-by: Clayton Schneider <clayton-schneider@users.noreply.github.com>
Co-authored-by: hectorbenitez19 <hectorbenitez19@users.noreply.github.com>
Co-authored-by: Michael Hughes <mrmchughes@users.noreply.github.com>
Co-authored-by: Leopardfoot <Leopardfoot@users.noreply.github.com>

* Server side checking/handling

Co-authored-by: Clayton Schneider <clayton-schneider@users.noreply.github.com>
Co-authored-by: plocket <plocket@users.noreply.github.com>
Co-authored-by: Leopardfoot <Leopardfoot@users.noreply.github.com>

* consolidated form to single page

Co-authored-by: Clayton Schneider <clayton-schneider@users.noreply.github.com>
Co-authored-by: Michael Hughes <mrmchughes@users.noreply.github.com>
Co-authored-by: Leopardfoot <Leopardfoot@users.noreply.github.com>
Co-authored-by: plocket <plocket@users.noreply.github.com>

* WIP form #2

* Finished HomeInformation on single, CurrentHeatingSystem WIP

Co-authored-by: plocket <plocket@users.noreply.github.com>
Co-authored-by: Clayton Schneider <clayton-schneider@users.noreply.github.com>
Co-authored-by: Leopardfoot <Leopardfoot@users.noreply.github.com>
Co-authored-by: Camden Blatchly <camdenblatchly@users.noreply.github.com>

---------

Co-authored-by: plocket <plocket@users.noreply.github.com>
Co-authored-by: Clayton Schneider <clayton-schneider@users.noreply.github.com>
Co-authored-by: teykamp <teykamp@users.noreply.github.com>
Co-authored-by: teykamp <thomas@eykamp.com>
Co-authored-by: Jeff Korenstein <jkoren@users.noreply.github.com>
Co-authored-by: Leopardfoot <Leopardfoot@users.noreply.github.com>
Co-authored-by: hectorbenitez19 <hectorbenitez19@users.noreply.github.com>
Co-authored-by: Michael Hughes <mrmchughes@users.noreply.github.com>
Co-authored-by: Camden Blatchly <camdenblatchly@users.noreply.github.com>
@thadk thadk mentioned this issue Mar 1, 2025
Open
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
rules-engine Issues related to the Python rules engine
Projects
HEAT Rules Engine
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added isort, black, mypy codeforboston/home-energy-analysis-tool
2 participants
@jkwan2011 @alanisaac