Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Pass stack-trace along with Exception #108

Merged
merged 7 commits into from
Jan 28, 2024
Merged

Conversation

codekeyz
Copy link
Owner

Description

Currently, It's hard to debug when exceptions are thrown because Pharaoh doesn't expose the stack trace. This should fix that.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@codekeyz codekeyz changed the title chore: Pass stacktrace along with Exception chore: Pass stack-trace along with Exception Jan 27, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2024

Codecov Report

Attention: 29 lines in your changes are missing coverage. Please review.

Comparison is base (f01f099) 75.29% compared to head (aaebad2) 74.68%.

Files Patch % Lines
packages/spanner/lib/src/tree/tree.dart 42.10% 11 Missing ⚠️
packages/pharaoh/lib/src/http/response_impl.dart 60.00% 6 Missing ⚠️
packages/pharaoh/lib/src/core_impl.dart 75.00% 4 Missing ⚠️
...ackages/pharaoh/lib/src/shelf_interop/adapter.dart 0.00% 2 Missing ⚠️
packages/spanner/lib/src/parametric/utils.dart 0.00% 2 Missing ⚠️
packages/pharaoh/lib/src/http/request_impl.dart 50.00% 1 Missing ⚠️
packages/pharaoh/lib/src/http/response.dart 75.00% 1 Missing ⚠️
packages/pharaoh/lib/src/utils/utils.dart 0.00% 1 Missing ⚠️
...ackages/spanner/lib/src/parametric/definition.dart 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #108      +/-   ##
==========================================
- Coverage   75.29%   74.68%   -0.62%     
==========================================
  Files          34       34              
  Lines        1093     1114      +21     
==========================================
+ Hits          823      832       +9     
- Misses        270      282      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codekeyz codekeyz merged commit a307621 into main Jan 28, 2024
2 checks passed
@codekeyz codekeyz deleted the bugfix/pharaoh-issues branch January 28, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants