Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Rework req res hook #138

Merged
merged 9 commits into from
Jan 22, 2025
Merged

chore: Rework req res hook #138

merged 9 commits into from
Jan 22, 2025

Conversation

codekeyz
Copy link
Owner

@codekeyz codekeyz commented Jan 17, 2025

  • Re-implement route groups (Reconciling Spanner Nodes & Index Offset)
  • Re-implement Request/Response Hooks.

@codekeyz codekeyz self-assigned this Jan 17, 2025
@codekeyz codekeyz added the enhancement New feature or request label Jan 17, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 59.04762% with 43 lines in your changes missing coverage. Please review.

Project coverage is 70.87%. Comparing base (0be851e) to head (201b9a4).

Files with missing lines Patch % Lines
packages/spanner/lib/src/tree/tree.dart 61.36% 17 Missing ⚠️
...ges/pharaoh/lib/src/middleware/request_logger.dart 0.00% 11 Missing ⚠️
packages/spanner/lib/src/route/action.dart 0.00% 9 Missing ⚠️
packages/pharaoh/lib/src/http/router.dart 86.66% 2 Missing ⚠️
...ackages/spanner/lib/src/parametric/definition.dart 0.00% 2 Missing ⚠️
packages/pharaoh/lib/src/http/request_impl.dart 0.00% 1 Missing ⚠️
...es/pharaoh/lib/src/http/router/router_handler.dart 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #138      +/-   ##
==========================================
- Coverage   71.51%   70.87%   -0.64%     
==========================================
  Files          45       43       -2     
  Lines        1534     1528       -6     
==========================================
- Hits         1097     1083      -14     
- Misses        437      445       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codekeyz codekeyz marked this pull request as ready for review January 22, 2025 19:45
@codekeyz codekeyz merged commit f21d4db into main Jan 22, 2025
2 checks passed
@codekeyz codekeyz deleted the chore/refactor-req-res-hook branch January 22, 2025 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants