Cumulative, reconstructed changes. #1630
Conversation
Add enum Type to ActionEvent, add and use new constructors so the events we generate are typed at birth. For example, this allows ActionEvents associated with pointerPressed to be differentiated from ActionEvents associated with pointerReleased.
This is expected in standard java environments, and was trivial to add.
This useful variant copies a rectangle from one image to another.
|
The two other commits shouldn't be a part of this merge. The printStackTrace change won't actually work and won't be exposed to developers as a result of this change. drawImageArea doesn't work on quite a few platforms and you will run into device problems which we will then need to fix. |
|
@shannah can you integrate only the first patch as the other two shouldn't be integrated. |
|
Done |
|
I can live without the public drawImageArea for now. For the record, I would use it to The printStackTrace change is harder to dispense with. I really like getting stack traces The current state, with one picked commit and two rejected, it seems impossible for me |
|
Here is the rough process to submit only a single change.
|
|
As I said above, changing these things locally won't really matter if you send a build to the build servers. |
|
printStackTrace is in the VM, so presumably there would be no hope without addiing an equivalent to each vm. I would be happy crossing those bridges one at a time. |
|
Cross all of them and submit a complete patch with the C code for the iOS VM etc. |
|
I don't have the capability to develop and test for all your platforms. I can resubmit the |
Add type information for ActionEvents. The
exact set of types and their names is subject to change, but this is a best guess.
Add printStackTrace(PrintStream), easy and useful
Make a existing drawImage variant public.