Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RadarChart #2876

Merged
merged 3 commits into from
Aug 15, 2019
Merged

Add RadarChart #2876

merged 3 commits into from
Aug 15, 2019

Conversation

daviddaytw
Copy link
Contributor

Hi, I'm new to CN1.
I need a RadarChart for my school project.
So I made one by modifying PieChart and DounghtChart

@codenameone
Copy link
Collaborator

Thanks!
This seems like a really nice contribution. Can you add a sample indicating the usage of this new chart?
See this about the new samples tool: https://www.codenameone.com/blog/sheets-samples.html

If you could we'd appreciate a few JavaDoc corrections. Even basic {@inheritdoc} tags make a huge difference in the generated Javadoc. There are also some copy/paste JavaDoc issues such as the comment "The doughnut chart rendering class" in the RadarChart class.

@codenameone codenameone added this to the Version 7.0 milestone Aug 7, 2019
AreaSeries method rename
@daviddaytw
Copy link
Contributor Author

Thanks for review the PR so fast , I'm glad to help!

It might take me a week or more to make a sample.
I'm not quite familiar with those...

@amigax
Copy link

amigax commented Aug 7, 2019 via email

@codenameone codenameone merged commit 7855a76 into codenameone:master Aug 15, 2019
@codenameone
Copy link
Collaborator

Thanks!

@shai-almog
Copy link
Collaborator

@all-contributors please add @dj6082013 for code

@allcontributors
Copy link
Contributor

@shai-almog

I've put up a pull request to add @dj6082013! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants