Set cloud region and tags #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Btw, here's the filtered view for this workflow https://cloud.coiled.io/clusters?tagFilters=workflow%3Aetl-tpch&viewedAccount=%22dask-engineering%22 |
jrbourbeau
commented
Feb 13, 2024
pipeline/settings.py
Outdated
Comment on lines
30
to
34
| coiled_options = { | ||
| "local": LOCAL, | ||
| "region": REGION, | ||
| "tags": {"workflow": "etl-tpch"}, | ||
| } |
There was a problem hiding this comment.
Centralizing coiled_options makes sense from a pure software perspective. Though it occurs to me that when demo-ing it might be better to have these explicitly listed out in the @coiled.function call. @mrocklin any preference?
There was a problem hiding this comment.
I'm going to go with inlining these instead, which will be slightly better for demo-ing
There was a problem hiding this comment.
Yeah, I think that we want these inlined. Thanks for thinking through this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now automatically detect the AWS region being used and use that region for all Coiled VMs. We also set tags for tracking VMs from this workflow (requires https://github.com/coiled/platform/pull/4661).
I also moves all the info from
pipeline/files.pyintopipeline/settings.py. Now all configuration happens in one file.Closes #8