Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/increased evaluation window #91

Merged
merged 28 commits into from
Mar 7, 2025

Conversation

peterc-yuma
Copy link
Collaborator

No description provided.

@peterc-yuma peterc-yuma force-pushed the enhancement/increased-evaluation-window branch from bd48ecc to 81288cd Compare March 5, 2025 22:06
@peterc-yuma peterc-yuma marked this pull request as ready for review March 7, 2025 16:12
@peterc-yuma peterc-yuma requested a review from matt-yuma March 7, 2025 16:12
@peterc-yuma peterc-yuma requested a review from umocm March 7, 2025 16:12
Copy link
Collaborator

@matt-yuma matt-yuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can address all or none or my comments in this PR. But if we decide to ignore my comments, let's consider making backlog tasks before merging this

@peterc-yuma peterc-yuma merged commit 236aadb into dev Mar 7, 2025
6 checks passed
@peterc-yuma peterc-yuma deleted the enhancement/increased-evaluation-window branch March 7, 2025 20:41
peterc-yuma added a commit that referenced this pull request Mar 10, 2025
* Enhancement/increased evaluation window (#91)

* update the rewards to be calculated with the last 6 hours of predictions

* make evaluation window a config option

* update reward to properly get 6 hours of past data offset by one hour ago.

* add completeness to rewards calculation

* Just multiply the current rewards by the completeness score

* remove config options and introduce constants for the evaluation window

* release notes and version incremementing

---------

Co-authored-by: Peter | Yuma, a DCG Company <peter@yumaai.com>
@matt-yuma matt-yuma mentioned this pull request Mar 10, 2025
peterc-yuma added a commit that referenced this pull request Mar 10, 2025
* Enhancement/increased evaluation window (#91)

* update the rewards to be calculated with the last 6 hours of predictions

* make evaluation window a config option

* update reward to properly get 6 hours of past data offset by one hour ago.

* add completeness to rewards calculation

* Just multiply the current rewards by the completeness score

* remove config options and introduce constants for the evaluation window

* release notes and version incremementing

---------

Co-authored-by: Peter | Yuma, a DCG Company <peter@yumaai.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants