-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement/increased evaluation window #91
Merged
Merged
+103
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…edictions, regardless of if they responded to all
bd48ecc
to
81288cd
Compare
matt-yuma
requested changes
Mar 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can address all or none or my comments in this PR. But if we decide to ignore my comments, let's consider making backlog tasks before merging this
Loading status checks…
matt-yuma
approved these changes
Mar 7, 2025
umocm
approved these changes
Mar 7, 2025
peterc-yuma
added a commit
that referenced
this pull request
Mar 10, 2025
* Enhancement/increased evaluation window (#91) * update the rewards to be calculated with the last 6 hours of predictions * make evaluation window a config option * update reward to properly get 6 hours of past data offset by one hour ago. * add completeness to rewards calculation * Just multiply the current rewards by the completeness score * remove config options and introduce constants for the evaluation window * release notes and version incremementing --------- Co-authored-by: Peter | Yuma, a DCG Company <peter@yumaai.com>
Merged
peterc-yuma
added a commit
that referenced
this pull request
Mar 10, 2025
* Enhancement/increased evaluation window (#91) * update the rewards to be calculated with the last 6 hours of predictions * make evaluation window a config option * update reward to properly get 6 hours of past data offset by one hour ago. * add completeness to rewards calculation * Just multiply the current rewards by the completeness score * remove config options and introduce constants for the evaluation window * release notes and version incremementing --------- Co-authored-by: Peter | Yuma, a DCG Company <peter@yumaai.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.