-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove "export" option from build #262
Conversation
hey @GuilleAngulo mind giving me your thoughts on this? |
this seemed to deploy fine here but having an issue after cloning the project to see if isr would work so debugging that |
okay, added an i think we should reassess that dependency on node-canvas and explore other options like we were talking about before don't want to be stuck on node 12, but unsure why it's doing that 🤷 |
last comment 😂 i deployed with the
the link there is broken though but at least Next.js features should now generally work |
README.md
Outdated
* [Essential Next.js Plugin](https://github.com/netlify/netlify-plugin-nextjs) (recommended) | ||
* [Exporting the project](https://nextjs.org/docs/advanced-features/static-html-export) via `next export` | ||
|
||
**Essential Next.js Plugin** should be provided as an option when you're first importing a project based on this starter. If it's not, you can install this plugin using the Netlify Plugins directory. This will allow Netlify to take full advantage of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ops, I think the last part of the sentence is missing here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤦♀️ haha thanks for catching that
I think it makes totally sense, i'll try to deploy as well to test it |
Including
next export
in the build command prevents some features from working out of the box with this starter. Particularly Netlify being able to use its plugin to provide Next.js features like ISR.Fixes #261