Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace 'typeset' usage in sh with 'command' #124

Merged
merged 1 commit into from
Oct 27, 2018
Merged

replace 'typeset' usage in sh with 'command' #124

merged 1 commit into from
Oct 27, 2018

Conversation

dirk-thomas
Copy link
Member

Addresses the problem reported in ros-infrastructure/ros_buildfarm#585 (comment) that a .sh snippet uses typeset which is bash specific.

@dirk-thomas dirk-thomas added bug Something isn't working review Waiting for review (Kanban column) labels Oct 27, 2018
@dirk-thomas dirk-thomas self-assigned this Oct 27, 2018
@dirk-thomas dirk-thomas requested a review from cottsay October 27, 2018 00:52
cottsay
cottsay approved these changes Oct 27, 2018
View reviewed changes
Copy link
Member

@cottsay cottsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works as expected. Thanks for following up with a fix so quickly.

@dirk-thomas dirk-thomas merged commit 242f030 into master Oct 27, 2018
@dirk-thomas dirk-thomas added this to the 0.3.11 milestone Oct 27, 2018
@dirk-thomas dirk-thomas removed the review Waiting for review (Kanban column) label Oct 27, 2018
@dirk-thomas dirk-thomas deleted the replace_typeset_with_command branch October 27, 2018 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cottsay cottsay cottsay approved these changes

Assignees

@dirk-thomas dirk-thomas

Labels
bug Something isn't working
Milestone
0.3.11
Development

Successfully merging this pull request may close these issues.
2 participants
@dirk-thomas @cottsay