Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace winconsole dependency with winapi #68

Merged
merged 3 commits into from
Nov 10, 2019

Conversation

kurtlawrence
Copy link
Collaborator

PR that changes the set_virtual_terminal function to use the crate winapi over winconsole.

Motivation

  • Reduce (transitive) dependency count
  • Reduce dependency size (fewer winapi features)

Changes

Inspired by @noxabellus comment in #56, uses winapi calls to set virtual terminal.
This changes the function signature to return a void rather than a result. I would like some feedback whether this is considered a breaking change given we are reducing the return type. Does this mean major bump or can we just bump minor.

Additional Notes

This will effectively negate #60 and #66.

@kurtlawrence
Copy link
Collaborator Author

To further reduce any possible breaking changes, the set_virtual_terminal returns a dummy Result<(), ()> which is always Ok(()).

@kurtlawrence kurtlawrence merged commit 8035bb9 into colored-rs:master Nov 10, 2019
@kurtlawrence kurtlawrence deleted the use-winapi branch November 10, 2019 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant