Replace winconsole dependency with winapi #68
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR that changes the
set_virtual_terminal
function to use the cratewinapi
overwinconsole
.Motivation
winapi
features)Changes
Inspired by @noxabellus comment in #56, uses
winapi
calls to set virtual terminal.This changes the function signature to return a void rather than a result. I would like some feedback whether this is considered a breaking change given we are reducing the return type. Does this mean major bump or can we just bump minor.
Additional Notes
This will effectively negate #60 and #66.