Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More logger cleanups #4658

Merged
merged 5 commits into from
Mar 6, 2025
Merged

More logger cleanups #4658

merged 5 commits into from
Mar 6, 2025

Conversation

lihaoyi
Copy link
Member

@lihaoyi lihaoyi commented Mar 5, 2025 •
edited
Loading

Another part of #3603

More narrowing of the Logger interface so we can figure out what really needs to be there

  • Moved colored, infoColor, errorColor to the prompt object since it's not typically overriden
  • Inlined the subLogger calls at its one call-site

@lihaoyi lihaoyi mentioned this pull request Mar 6, 2025
Closed
@lihaoyi lihaoyi merged commit 0fbf041 into com-lihaoyi:main Mar 6, 2025
32 of 33 checks passed
@lefou lefou added this to the 0.13.0 milestone Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.13.0
Development

Successfully merging this pull request may close these issues.
2 participants
@lihaoyi @lefou