Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add def warn(s: String): Unit to Logger #4664

Merged
merged 2 commits into from
Mar 7, 2025
Merged

Add def warn(s: String): Unit to Logger #4664

merged 2 commits into from
Mar 7, 2025

Conversation

lolgab
Copy link
Member

@lolgab lolgab commented Mar 6, 2025 •
edited
Loading

@lolgab lolgab marked this pull request as ready for review March 6, 2025 18:08
@lolgab lolgab requested review from lihaoyi and lefou and removed request for lihaoyi March 6, 2025 20:29
lefou
lefou approved these changes Mar 6, 2025
View reviewed changes
Copy link
Member

@lefou lefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@lefou lefou mentioned this pull request Mar 6, 2025
Merged
@lihaoyi lihaoyi merged commit c4f0246 into com-lihaoyi:main Mar 7, 2025
33 checks passed
@lefou lefou added this to the 0.13.0 milestone Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lefou lefou lefou approved these changes

@lihaoyi lihaoyi Awaiting requested review from lihaoyi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@lolgab @lefou @lihaoyi