Allow scheduling jobs with existing CIVs through API #3368
Comments
|
I might give this a try this week, although it is a short week with DIAG day on Wednesday and the AWS workshop on Thursday, so might not get to making a PR. |
amickan
added a commit
that referenced
this issue
Oct 7, 2024
This PR refactors the job creation code. Jobs, archive items and display sets now all use the same creation and validation logic. Errors from asynchronous input validation now get caught and are reported back to the user as error message on the Job object. The job is then cancelled and not executed. This PR also enables selecting existing images and files for jobs through the UI and enables re-using CIVs for existing values if possible. The same holds partially for the API view as well. It is not yet possible to create a job through the API with an existing non-image file. This was out of scope for this PR (DIAGNijmegen/rse-roadmap#335 (comment)) Part of DIAGNijmegen/rse-roadmap#335 Closes #3139 Closes #3325 Closes #3565 Partially addresses #3368 --------- Co-authored-by: James Meakin <12661555+jmsmkn@users.noreply.github.com>
|
Closing this in favour of: #3576 which is a more concise description of what is still missing for the API views. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
At the moment, when scheduling a job through the API, new CIVs are created for all inputs, even if an existing image is provided as input. The behavior when scheduling a job should match what we do on the "Try out algorithm" page, where we reuse CIVs when possible.
This relates to #3139 - both require a heavy refactoring of civ creation and validation around algorithm jobs.
The text was updated successfully, but these errors were encountered: