Code

Refactor job creation code#3465

Code

Merged

amickan merged 78 commits intomaincomic/grand-challenge.org:mainfrom job_refactoringcomic/grand-challenge.org:job_refactoringCopy head branch name to clipboardOct 7, 2024

+3,679-1,349

Commits

Commits on Aug 1, 2024

• Refactor algorithm job creation and civ creation

  amickan

  committed
  362d3c4

  Copy full SHA for 362d3c4

• Remove unused debug statements

  amickan

  committed
  82ebb57

  Copy full SHA for 82ebb57

• Remove unused code

  amickan

  committed
  1e595c7

  Copy full SHA for 1e595c7

• Update post serializer to use same validation code

  amickan

  committed
  724e7f3

  Copy full SHA for 724e7f3

• Move job creation to form_valid and serializer create methods

  amickan

  committed
  2ce04b0

  Copy full SHA for 2ce04b0

Commits on Aug 2, 2024

• Fix tests

  amickan

  committed
  89ad04a

  Copy full SHA for 89ad04a

• Small code improvements

  amickan

  committed
  e5324ee

  Copy full SHA for e5324ee

• Add API view tests and test for test_retrieve_existing_civs

  amickan

  committed
  4e89d98

  Copy full SHA for 4e89d98

• Undo commenting out middleware

  amickan

  committed
  85be1c7

  Copy full SHA for 85be1c7

Commits on Aug 21, 2024

• Merge main

  amickan

  committed
  1ee3796

  Copy full SHA for 1ee3796

• Fix typos

  amickan

  committed
  8006337

  Copy full SHA for 8006337

• Complete API view tests

  amickan

  committed
  c42e4a7

  Copy full SHA for c42e4a7

Commits on Aug 23, 2024

• Consolidate InterfaceFormField logic

  amickan

  committed
  b584d08

  Copy full SHA for b584d08

• Add tests

  amickan

  committed
  e8d3580

  Copy full SHA for e8d3580

• Add test for inputs_complete

  amickan

  committed
  a89b8a3

  Copy full SHA for a89b8a3

• Make add_file_to_object idempotent

  amickan

  committed
  606818c

  Copy full SHA for 606818c

Commits on Aug 26, 2024

• Move util methods to serializer and job manager

  amickan

  committed
  1e32d75

  Copy full SHA for 1e32d75

• Small fixes

  amickan

  committed
  18c4521

  Copy full SHA for 18c4521

• Add object locking and atomic transaction marker to celery tasks

  amickan

  committed
  0fe7eb8

  Copy full SHA for 0fe7eb8

Commits on Aug 28, 2024

• Revert "Add object locking and atomic transaction marker to celery tasks"

  Show description for 6cb1eb9
  amickan

  committed
  6cb1eb9

  Copy full SHA for 6cb1eb9

• Address PR review

  amickan

  committed
  e9ce96d

  Copy full SHA for e9ce96d

Commits on Aug 29, 2024

• Catch more errors, add tests

  amickan

  committed
  49ac398

  Copy full SHA for 49ac398

• Replace TestCase instances with fixture

  amickan

  committed
  7afe9d3

  Copy full SHA for 7afe9d3

• Fix tests

  amickan

  committed
  6ac0154

  Copy full SHA for 6ac0154

• Update reformat inputs

  amickan

  committed
  3857d1c

  Copy full SHA for 3857d1c

• Do object locking and status update within transaction

  amickan

  committed
  d59e32e

  Copy full SHA for d59e32e

• Add permission checks to file upload view

  amickan

  committed
  d6ec56e

  Copy full SHA for d6ec56e

• Prepend interface slug on file upload view

  amickan

  committed
  ef574ec

  Copy full SHA for ef574ec

Commits on Aug 30, 2024

• Make widget name a child class property for file upload view

  amickan

  committed
  52465be

  Copy full SHA for 52465be

• Add object locking

  amickan

  committed
  2209161

  Copy full SHA for 2209161

• Catch all exceptions in async tasks

  amickan

  committed
  c872738

  Copy full SHA for c872738

• Fix tests

  amickan

  committed
  d38f02d

  Copy full SHA for d38f02d

• Refactor create_civ method

  amickan

  committed
  230e1a2

  Copy full SHA for 230e1a2

Commits on Sep 2, 2024

• Refactor error handling for civ creation

  amickan

  committed
  de459e9

  Copy full SHA for de459e9

Commits on Sep 12, 2024

• Address merge conflicts

  amickan

  committed
  69d4b6a

  Copy full SHA for 69d4b6a

• Don't raise error when job already provisioned

  amickan

  committed
  f9daede

  Copy full SHA for f9daede

• Change log level

  amickan

  committed
  78a04c7

  Copy full SHA for 78a04c7

• Resolve merge conflicts

  amickan

  committed
  8fc5ea8

  Copy full SHA for 8fc5ea8

• Rerun pre-commit

  amickan

  committed
  edfdfa3

  Copy full SHA for edfdfa3

Commits on Sep 16, 2024

• Make sure provision_job gets called only once

  amickan

  committed
  172014f

  Copy full SHA for 172014f

• Fix line ending changes by pycharm

  amickan

  committed
  b4d54a5

  Copy full SHA for b4d54a5

• Reintroduce checking for pending jobs

  amickan

  committed
  d7e4545

  Copy full SHA for d7e4545

• Refactor build_images notification sending

  amickan

  committed
  501b90c

  Copy full SHA for 501b90c

• Fix tests

  amickan

  committed
  35f5149

  Copy full SHA for 35f5149

• Merge branch 'main' into job_refactoring

  jmsmkn

  committed
  9e63eaf

  Copy full SHA for 9e63eaf

• Undo css changes

  jmsmkn

  committed
  5465984

  Copy full SHA for 5465984

Commits on Sep 18, 2024

• Merge main

  amickan

  committed
  329fdfa

  Copy full SHA for 329fdfa

• Redo migrations

  amickan

  committed
  e04402c

  Copy full SHA for e04402c

• Refactor error handling in build_images

  amickan

  committed
  fc5a8f2

  Copy full SHA for fc5a8f2

• Refactor CIV creation and validation

  amickan

  committed
  d2bc25f

  Copy full SHA for d2bc25f

Commits on Sep 19, 2024

• Merge main

  amickan

  committed
  736a3eb

  Copy full SHA for 736a3eb

• Merge branch 'main' into job_refactoring

  amickan

  committed
  0f5137f

  Copy full SHA for 0f5137f

• Redo migrations

  amickan

  committed
  399f219

  Copy full SHA for 399f219

• Add proper interface prefix to all interface form fields

  amickan

  committed
  91940ca

  Copy full SHA for 91940ca

• Add interface prefix in tests

  amickan

  committed
  0d3c3b5

  Copy full SHA for 0d3c3b5

• Redesign CIVData

  amickan

  committed
  6d24448

  Copy full SHA for 6d24448

• Use just one view for file uploads and list all CIVs a user has permission to use

  amickan

  committed
  cbd9210

  Copy full SHA for cbd9210

• Revert ValuesForInterfacesMixin changes

  amickan

  committed
  eabb979

  Copy full SHA for eabb979

Commits on Sep 20, 2024

• Add test for file_civs_user_has_permission_to_use

  amickan

  committed
  4f199d1

  Copy full SHA for 4f199d1

• Use VALIDATING_INPUTS status to determine execution readiness

  amickan

  committed
  1556b06

  Copy full SHA for 1556b06

• Fix get_metrics test

  amickan

  committed
  61038d0

  Copy full SHA for 61038d0

• Remove leftover non_interface_fields, unused template and test

  amickan

  committed
  ab237f8

  Copy full SHA for ab237f8

• Refactor error handling and notification sending

  amickan

  committed
  9811d01

  Copy full SHA for 9811d01

• Only update linked_object on upload session failure

  amickan

  committed
  7ab897f

  Copy full SHA for 7ab897f

• Fix tests

  amickan

  committed
  0803ac4

  Copy full SHA for 0803ac4

Commits on Sep 23, 2024

• Subset selectable files by interface and update job session js

  amickan

  committed
  44c40a2

  Copy full SHA for 44c40a2

• Remove leftover use of removed handle_error function

  amickan

  committed
  17adc36

  Copy full SHA for 17adc36

• Improve error message

  amickan

  committed
  8cb5901

  Copy full SHA for 8cb5901

• Fix tests

  amickan

  committed
  d2ce351

  Copy full SHA for d2ce351

• Update test error message

  amickan

  committed
  d4788a5

  Copy full SHA for d4788a5

Commits on Oct 1, 2024

• Merge branch 'main' into job_refactoring

  amickan

  committed
  1500f7f

  Copy full SHA for 1500f7f

• Addres review

  amickan

  committed
  11d9da2

  Copy full SHA for 11d9da2

Commits on Oct 2, 2024

• Unify file civ serving permission checks

  amickan

  committed
  96959dc

  Copy full SHA for 96959dc

• Switch to local import

  amickan

  committed
  cb01743

  Copy full SHA for cb01743

• Move permission checking to serving app

  amickan

  committed
  1008630

  Copy full SHA for 1008630

Commits on Oct 3, 2024

• Update annotation and test

  amickan

  committed
  0267657

  Copy full SHA for 0267657

• Resolve conflicts with main

  amickan

  committed
  0b469c7

  Copy full SHA for 0b469c7

• Redo migrations

  amickan

  committed
  6a6c3c5

  Copy full SHA for 6a6c3c5