Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make consistent html titles with breadcrumbs for archives app #3580

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Make consistent html titles with breadcrumbs for archives app #3580

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8998333
Fix HTML titles for archives app
ammar257ammar Oct 6, 2024
73d4385
Fix making archive permissions accessible in template title scope
ammar257ammar Oct 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions app/grandchallenge/archives/templates/archives/archive_cases_list.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@
{% load guardian_tags %}
{% load static %}

{% block title %}
Images - {{ archive.title }} - {{ block.super }}
{% endblock %}

{% block breadcrumbs %}
<ol class="breadcrumb">
<li class="breadcrumb-item"><a href="{% url 'archives:list' %}">Archives</a></li>
Expand Down
4 changes: 4 additions & 0 deletions app/grandchallenge/archives/templates/archives/archive_cases_to_reader_study_form.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@
{% load static %}
{% load url %}

{% block title %}
Add Items to Reader Study - Items - {{ block.super }}
{% endblock %}

{% block breadcrumbs %}
<ol class="breadcrumb">
<li class="breadcrumb-item"><a href="{% url 'archives:list' %}">Archives</a>
Expand Down
2 changes: 1 addition & 1 deletion app/grandchallenge/archives/templates/archives/archive_detail.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
{% load static %}

{% block title %}
{{ object.title }} - {{ block.super }}
{{ object.title }} - Archives - {{ block.super }}
{% endblock %}

{% block breadcrumbs %}
Expand Down
2 changes: 1 addition & 1 deletion app/grandchallenge/archives/templates/archives/archive_form.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
{% load url %}

{% block title %}
{% if object %}Update{% else %}New{% endif %} Archive - {{ block.super }}
{% if object %}Update{% else %}New{% endif %} Archive -{% if object %} {{ object.title }} -{% endif %} {{ block.super }}
{% endblock %}

{% block breadcrumbs %}
Expand Down
2 changes: 1 addition & 1 deletion app/grandchallenge/archives/templates/archives/archive_item_job_list.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
{% load meta_attr %}

{% block title %}
Algorithm Results - {{ block.super }}
Jobs - {{ object.pk }} - {{ block.super }}
{% endblock %}

{% block breadcrumbs %}
Expand Down
2 changes: 1 addition & 1 deletion app/grandchallenge/archives/templates/archives/archive_upload_session_create.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
{% load static %}

{% block title %}
Add Items to Archive - {{ block.super }}
Add Items - {{ archive.title }} - {{ block.super }}
{% endblock %}

{% block breadcrumbs %}
Expand Down
4 changes: 4 additions & 0 deletions app/grandchallenge/archives/templates/archives/archive_user_groups_form.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
{% extends "groups/groups_form_base.html" %}
{% load url %}

{% block title %}
Add user - {{ object.title }} - {{ block.super }}
{% endblock %}

{% block breadcrumbs %}
<ol class="breadcrumb">
<li class="breadcrumb-item"><a href="{% url 'archives:list' %}">Archives</a></li>
Expand Down
4 changes: 4 additions & 0 deletions app/grandchallenge/archives/templates/archives/archivepermissionrequest_form.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@
{% load clean from bleach %}
{% load guardian_tags %}

{% block title %}
{% get_obj_perms request.user for archive as "archive_perms" %}
{% if "change_archive" in archive_perms %}Review access request{% else %}Request access{% endif %} - {{ archive.title }} - {{ block.super }}
{% endblock %}

{% block breadcrumbs %}
{% get_obj_perms request.user for archive as "archive_perms" %}
Expand Down
2 changes: 1 addition & 1 deletion app/grandchallenge/archives/templates/archives/archivepermissionrequest_list.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
{% load static %}

{% block title %}
Permission Requests - {{ block.super }}
Permission Requests - {{ archive.title }} - {{ block.super }}
{% endblock %}

{% block breadcrumbs %}
Expand Down