Fix auto accepting pending requests upon verification #3659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmsmkn
reviewed
Oct 28, 2024
jmsmkn
reviewed
Oct 28, 2024
amickan
reviewed
Oct 28, 2024
amickan
approved these changes
Oct 30, 2024
|
@ammar257ammar what do you want to do with this? If it is ready for review then you need to mark it as ready for review. |
ammar257ammar
deleted the
auto_accept_pending_requests_upon_verification
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix relates to issue #2461 and PR #3514. The issue is that the logic of auto accepting pending requests upon verification was implemented in the save() method of the model. However, in Admin, the actions are performed as an update on the queryset which does not trigger the save() method, and similar behaviour affected the proper handling of permissions since the queryset update did not trigger the pre_save signals.