Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Pin compnerd/gha-setup-vsdevenv to SHA #22

Merged
merged 2 commits into from
Oct 21, 2023

Conversation

keelerm84
Copy link
Contributor

Some security policies require all external GitHub Actions to be pinned
to a specific SHA. This typically also applies to transitive
dependencies.

Usage of dsaltares/fetch-gh-release-asset is already pinned, so
pinning the only other GHA allows for safely pinning this action as
well.

Some security policies require all external GitHub Actions to be pinned
to a specific SHA. This typically also applies to transitive
dependencies.

Usage of `dsaltares/fetch-gh-release-asset` is already pinned, so
pinning the only other GHA allows for safely pinning this action as
well.
@keelerm84
Copy link
Contributor Author

Hello 👋🏼 and thank you for your work on creating this github action!

I realize this is a change you may not be interested in supporting, and no worries if that is the case. But before I forked it to satisfy a compliance requirement, I thought I would run it by you.

LMK and once again, thank you for your open source contributions!

@compnerd
Copy link
Owner

Hmm, what do you think of this instead? I can roll a release of gha-setup-vsdevenv, and then we pin to that release revision instead? I think that pinning to a random revision that is "main" is less than ideal.

@compnerd compnerd merged commit 325a5c6 into compnerd:main Oct 21, 2023
@keelerm84 keelerm84 deleted the pin-dependency branch October 23, 2023 14:51
@keelerm84
Copy link
Contributor Author

Hmm, what do you think of this instead? I can roll a release of gha-setup-vsdevenv, and then we pin to that release revision instead? I think that pinning to a random revision that is "main" is less than ideal.

Sounds great to me. Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants