Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gh instead of dsaltares/fetch-gh-release-asset to fetch asset #31

Conversation

amonshiz
Copy link
Contributor

The action dsaltares/fetch-gh-release-asset appears to be abandoned. There hasn't been a release in about a year and the maintainer is not responding to requests to update to using Node 20. This is a problem because GitHub has deprecated Node 16 and will remove it in Spring 2024. Instead, let's just use the gh CLI directly which can do the same as dsaltares/fetch-gh-release-asset, especially in the simple method we are using it within this action.

Copy link
Owner

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks like the right thing to do. I can see value in this outside of ignoring the warnings as well - it reduces the overall supply chain attack vector.

@compnerd compnerd merged commit 8f43ccc into compnerd:main Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants