Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpu_features: fix cross-build arm64 on Apple OS and fix bundle install #6233

Merged
merged 4 commits into from
Jul 9, 2021
Merged

cpu_features: fix cross-build arm64 on Apple OS and fix bundle install #6233

merged 4 commits into from
Jul 9, 2021

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Jul 8, 2021 •
edited
Loading

Specify library name and version: lib/1.0

These workarounds may be removed when conan-io/conan#8026 will be ready and merged

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@SpaceIm SpaceIm force-pushed the fix/cpu_features-cross-compile branch 2 times, most recently from 5da4257 to bfa6a65 Compare July 8, 2021 13:49
@SpaceIm SpaceIm changed the title cpu_features: fix cross-build to arm based arch and to iOS/tvOS/watchOS cpu_features: fix cross-build arm64 on Apple OS and fix bundle install Jul 8, 2021
@SpaceIm SpaceIm force-pushed the fix/cpu_features-cross-compile branch from bfa6a65 to 576b53d Compare July 8, 2021 13:55
@github-actions github-actions bot mentioned this pull request Jul 8, 2021
Open
@SpaceIm
Copy link
Contributor Author

SpaceIm commented Jul 8, 2021

For upcoming versions, a PR of interest: google/cpu_features#150

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Jul 8, 2021

fix of BUNDLE DESTINATION submitted upstream: google/cpu_features#177

@conan-center-bot
Copy link
Collaborator

All green in build 4 (576b53d5fe0ca89e65a8b7c778a9c633da87a1c7):

  • cpu_features/0.6.0@:
    All packages built successfully! (All logs)

@SSE4 SSE4 requested a review from uilianries July 9, 2021 12:03
@conan-center-bot conan-center-bot merged commit cec7648 into conan-io:master Jul 9, 2021
@SpaceIm SpaceIm deleted the fix/cpu_features-cross-compile branch July 9, 2021 15:40
AndreyMlashkin pushed a commit to AndreyMlashkin/conan-center-index that referenced this pull request Jul 19, 2021
@SpaceIm @AndreyMlashkin
(conan-io#6233) cpu_features: fix cross-build arm64 on Apple OS and f…
d58ed53 
…ix bundle install

* allow to compile to arm64 on Apple OS

* properly test CMake target

* reorder methods

* fix cross-build to iOS/tvOS/watchOS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SSE4 SSE4 SSE4 approved these changes

@uilianries uilianries uilianries approved these changes

@prince-chrismc prince-chrismc prince-chrismc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SpaceIm @conan-center-bot @SSE4 @uilianries @prince-chrismc