Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #79

Merged
merged 5 commits into from
Jun 18, 2020
Merged

Dev #79

merged 5 commits into from
Jun 18, 2020

Conversation

wachsylon
Copy link
Contributor

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

@ocefpaf
Copy link
Member

ocefpaf commented May 14, 2020

You'll probably need to rebuild cmor first.

@Try2Code
Copy link
Contributor

hi @wachsylon!

I built the package from your 'dev' branch and installed it with conda install --offline. but then I got 2 missing shared object in the evironment: libproj.so.19 and libjson-c.so.4
but that might be expectable since I build from source

@wachsylon
Copy link
Contributor Author

You'll probably need to rebuild cmor first.

With the cmor-feedstock for conda-forge or a new version from home repo?

@ocefpaf
Copy link
Member

ocefpaf commented May 19, 2020

With the cmor-feedstock for conda-forge or a new version from home repo?

Just a new re-rendered version would do but you can update it the latest version upsream too if you want.

@wachsylon
Copy link
Contributor Author

@ocefpaf
For the new CMOR version and the new CDO file, it finally seems to work :)

@ocefpaf
Copy link
Member

ocefpaf commented Jun 17, 2020

LGTM! Merge away!

@wachsylon
Copy link
Contributor Author

Great.

LGTM! Merge away!

How?

@ocefpaf
Copy link
Member

ocefpaf commented Jun 18, 2020

I though you had commit rights here. Sorry.

@ocefpaf ocefpaf merged commit 2594719 into conda-forge:dev Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants