Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] run test suite for libgrpc #321

Merged
merged 9 commits into from
Feb 28, 2025
Merged

Conversation

h-vetinari
Copy link
Member

Rebase #311 onto main

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Feb 28, 2025

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.
  • ℹ️ The recipe is not parsable by parser conda-recipe-manager. The recipe can only be automatically migrated to the new v1 format if it is parseable by conda-recipe-manager.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13587000216. Examine the logs at this URL for more detail.

@h-vetinari h-vetinari force-pushed the ctest_main branch 2 times, most recently from bbdcd41 to 834174f Compare February 28, 2025 08:19
there's no gRPC_GTEST_PROVIDER option, apparently

use vendored benchmark (due to reliance on internal symbols)
using `git_url:` changes the patch application invocation from `patch`
to `git am -3`, which fails if we're patching something that has no
history (and thus the hashes/ancestors in the patch are fake)
…dfe3c322, and conda-forge-pinning 2025.02.27.15.37.26
@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Feb 28, 2025

Hi! This is the friendly automated conda-forge-linting service.

I failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint --conda-forge . from the recipe directory. You can also examine the workflow logs for more detail.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13597823650. Examine the logs at this URL for more detail.

@h-vetinari
Copy link
Member Author

Linter failure is unrelated

@h-vetinari h-vetinari marked this pull request as ready for review February 28, 2025 23:04
@h-vetinari
Copy link
Member Author

Alright, with the unvendoring of upb around the corner in #394, I really want us to test that the resulting library is actually working. Upstream will rightly say that switching out upb "voids the warranty", but unfortunately we don't have a good alternative. Running the test suite at least gets us most of the way back to proving that the library is still ~fully functional. Windows unfortunately is both going to be too onerous for now to build (there are so many test configs in CMakeLists.txt that would constantly need patching), so let's just use unix on x64 as our canaries.

@h-vetinari h-vetinari merged commit 6c71158 into conda-forge:main Feb 28, 2025
1 of 9 checks passed
@h-vetinari h-vetinari deleted the ctest_main branch February 28, 2025 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants