-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate to libprotobuf321 #137
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
this wasn't solvable for some reason... pytorch-cpu (0) Error: not solvable (bot CI job): main: |
…nda-forge-pinning 2022.09.25.18.08.47
@conda-forge-admin please rerender |
Maybe this file needs to be updated for OSX https://github.com/ngam/pytorch-cpu-feedstock/blob/libprotobuf/recipe/conda_build_config.yaml#L1 |
…nda-forge-pinning 2022.09.25.18.08.47
@conda-forge-admin please rerender |
…nda-forge-pinning 2022.09.25.18.08.47
That's there since 8e4ce19. Ideally things should be fine if I remember looking this up once... Based on https://developer.apple.com/support/xcode/, it looks we need to stay with xcode<14, otherwise we don't have support for deployment targets <11 anymore (or add |
i think lief-dev is now old, and just lief 11.2 or something is out. |
Good catch. I hope we can still keep the sdk at 12.3 (that's how we enable MPS for osx) |
This needs: asmjit/asmjit@c598476 |
maybe we should just downgrade the c ompiler. |
@hmaarrfk no rush on this. I think it would be reasonable to get it done when the next minor pytorch is out. I have no idea where to start with debugging such a failure... |
compilers often increase severity on "bad practices" with newer versions. I've linked to the patch that addressed this. It seems that for now, the easiest might be to downgrade the compiler |
…nda-forge-pinning 2022.09.25.18.08.47
1252383
to
43da1ac
Compare
Not merging this makes pytorch and all dependent packages run into the same kind of solvability problems we were discussing for tf. So while we shouldn't perhaps be rushing unduly, we should definitely get this in as soon as time allows, and not wait for the next version. |
Yes, this is what I meant. I think the issue is resolved now though 😄 |
I can build the cuda ones unless you wanna do it yourself, hmaarrfk. Let me know |
i don't have the compute power right now to build. so if you can build that would be great! |
Ok, I will get this done late Tue or Wed |
building now, surprisingly this takes significantly longer than the tensorflow builds in my setup... is there some sort of a caching mechanism we can activate? In the tensorflow builds, bazel automatically caches everything and I rely on that to accelerate the builds... Also, @hmaarrfk, since you are the primary one here, how much longer do you want to keep 11.1 and 11.0 (as well as 10.2)? I am building them all (i.e. not editing this PR) |
i think many downstream packages are still stuck on older cuda. I owuld like to keep the 11 series. |
I'm probably duplicating effort. But I started build too. |
Well, at least build 11.0 and 10.2 pls. I am done with 11.2 and 11.1. I can upload now. I stopped my build. Hopefully you see this and focus on 10.2 and 11.0... |
ok i've started with 10.2. historically it has 3 hours per build. So maybe 24 hours. |
How are we doing on this? If things didn't complete, I am happy to build some of the remaining ones. I would say it takes on the order of 5 hours on my end (compared to your 24 hours), so... |
I am going to continue building just in case. The builds will be uploaded in less than 5 hours (hopefully) |
sorry about the delay, tbh, i had the builds, but ultimately more pressing fires happened :/ this is the main issue with CFEP03, it centralizes too much "power" |
I'll wait for your builds, it makes the copying process more streamlined. |
Okay, all uploaded: https://anaconda.org/ngam |
In #137 (comment) I have one sample log; other logs exist, but I need to anonymize them and upload them. I can do that, let me know if you want to seem them. I used your automating script with only a small edit to make it work for Singularity. |
thanks! |
Thank YOU. I know this is annoying especially for you, so thank you for doing this for the community all the time and for your patience. |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)