Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added PySparse #6586

Merged
merged 32 commits into from
Sep 10, 2018
Merged

Added PySparse #6586

merged 32 commits into from
Sep 10, 2018

Conversation

guyer
Copy link
Contributor

@guyer guyer commented Aug 30, 2018

No description provided.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/pysparse) and found some lint.

Here's what I've got...

For recipes/pysparse:

  • Using pinned numpy packages is a deprecated pattern. Consider using the method outlined here.

For recipes/pysparse:

  • Using toolchain directly in this manner is deprecated. Consider using the compilers outlined here.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/pysparse) and found some lint.

Here's what I've got...

For recipes/pysparse:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [15]

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/pysparse) and found it was in an excellent condition.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/pysparse) and found some lint.

Here's what I've got...

For recipes/pysparse:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [23]

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/pysparse) and found it was in an excellent condition.

Hopefully fortran is what's invoking vc9
and hopefully we don't need it
@guyer
Copy link
Contributor Author

guyer commented Sep 6, 2018

@conda-forge-coordinator, @conda-forge-manager: this recipe passed all checks seven days ago. Can it be merged?

[FWIW, I'm trying to "ping @conda-forge/staged-recipes to request action", but GFM doesn't recognize that @mention]

@marcelotrevisani
Copy link
Member

marcelotrevisani commented Sep 7, 2018

Hi, sorry for the delay , sometime it happens :/

I will review your PR right now

@marcelotrevisani
Copy link
Member

If you read the log of the CI, you will see that your project is not being packaged.

I need to investigate that

@marcelotrevisani
Copy link
Member

marcelotrevisani commented Sep 10, 2018

@ocefpaf , could you please take a look on that? The package is not being created.

+ xargs -r /usr/bin/sudo -n yum install -y
+ grep -v -e '^#' -e '^$'
+ xargs -n1 cat
+ find /home/conda/conda-recipes -mindepth 2 -maxdepth 2 -type f -name yum_requirements.txt
+ test 1 == 1
+ python /home/conda/.ci_support/build_all.py /home/conda/conda-recipes
The update_index function has changed to index all subdirs at once.  You're pointing it at a single subdir.  Please update your code to point it at the channel root, rather than a subdir.
Setting build arch. This is only useful when pretending to be on another arch, such as for rendering necessary dependencies on a non-native arch. I trust that you know what you're doing.
rendering /home/conda/conda-recipes/pysparse for linux-64
Setting build platform. This is only useful when pretending to be on another platform, such as for rendering necessary dependencies on a non-native platform. I trust that you know what you're doing.
invalid recipe dir: /home/conda/conda-recipes/pysparse - skipping
Computed that there are 0 distributions to build from 1 recipes
Nothing to do
+ touch /home/conda/staged-recipes/build_artifacts/conda-forge-build-done

@marcelotrevisani
Copy link
Member

ping @conda-forge/staged-recipes


build:
number: 0
skip: True # [not py27]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guyer and @marcelotrevisani let's see if this fixes it.

@ocefpaf
Copy link
Member

ocefpaf commented Sep 10, 2018

invalid recipe dir: /home/conda/conda-recipes/pysparse - skipping

It does not like the directory :-/

@ocefpaf
Copy link
Member

ocefpaf commented Sep 10, 2018

@guyer and @marcelotrevisani now we got a real failure to deal with 😄
It does not like the patch, maybe try to re-generate it?

Extracting download
Applying patch: '/home/conda/conda-recipes/pysparse/brokenpip.patch'
Traceback (most recent call last):
  File "/home/conda/.ci_support/build_all.py", line 83, in <module>
    build_all(args.recipes_dir, args.arch)
  File "/home/conda/.ci_support/build_all.py", line 73, in build_all
    conda_build.api.build(list(d.keys()), config=config)
  File "/opt/conda/lib/python3.6/site-packages/conda_build/api.py", line 201, in build
    notest=notest, need_source_download=need_source_download, variants=variants)
  File "/opt/conda/lib/python3.6/site-packages/conda_build/build.py", line 2205, in build_tree
    notest=notest,
  File "/opt/conda/lib/python3.6/site-packages/conda_build/build.py", line 1359, in build
    try_download(m, no_download_source=False, raise_error=True)
  File "/opt/conda/lib/python3.6/site-packages/conda_build/render.py", line 568, in try_download
    source.provide(metadata)
  File "/opt/conda/lib/python3.6/site-packages/conda_build/source.py", line 655, in provide
    apply_patch(src_dir, join(metadata.path, patch), metadata.config, git)
  File "/opt/conda/lib/python3.6/site-packages/conda_build/source.py", line 564, in apply_patch
    patch_strip_level = _guess_patch_strip_level(files, src_dir)
  File "/opt/conda/lib/python3.6/site-packages/conda_build/source.py", line 504, in _guess_patch_strip_level
    histo = {i: 0 for i in range(maxlevel + 1)}
TypeError: unsupported operand type(s) for +: 'NoneType' and 'int'
Exited with code 1

@guyer
Copy link
Contributor Author

guyer commented Sep 10, 2018

@ocefpaf I regenerated the patch, but it's identical. What changed in the process? The patch was happily being applied since it was added two days ago.

@ocefpaf
Copy link
Member

ocefpaf commented Sep 10, 2018

The patch was happily being applied since it was added two days ago.

My impression is that the package was not getting built, so the patch was never applied, but I may be getting lost in the CI logs. Either way the patch looks oddly to big and it does not seem to be created with diff -Naur.

@guyer
Copy link
Contributor Author

guyer commented Sep 10, 2018

@ocefpaf I've rerun the diff with -Naur.

I don't know what to do about the "oddly to big" part. The available tarball is a disaster. Piles of code is missing completely. I already truncated the diff substantially by omitting the missing documentation and examples.

@ocefpaf
Copy link
Member

ocefpaf commented Sep 10, 2018

I don't know what to do about the "oddly to big" part.

I meant too big, sorry for the typo. The huge diff in the patch was a hint that something was not OK there. GitHub does not even render it! But it seems to be applying cleanly now.

@guyer
Copy link
Contributor Author

guyer commented Sep 10, 2018

GitHub will let you "View" the overly big diff. Adding -au to the formatting seems to be what was wanted.

Thanks for pointing out that it wasn't even building before the changes you and @marcelotrevisani made to my meta.yaml.

@ocefpaf ocefpaf merged commit 6f83d9b into conda-forge:master Sep 10, 2018
@guyer guyer deleted the pysparse branch September 10, 2018 19:44
@guyer
Copy link
Contributor Author

guyer commented Sep 13, 2018

@conda-forge/staged-recipes: @ocefpaf merged this to master three days ago (thank you!), but then it's been sitting in recipes/ since then. Is there something I should be doing to get the feedstock generated and build products pushed to anaconda.org?

@ocefpaf
Copy link
Member

ocefpaf commented Sep 13, 2018

See #6659 for more info on the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants