-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace deprecated test functions #310
Replace deprecated test functions #310
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Several observations:
conda_cli
is a pytest fixture and thus cannot be called directly- While we can import it as you've done here to expose the fixture to all tests in this file it is preferred to use the
pytest_plugins
constant to keep linters happy https://docs.pytest.org/en/stable/how-to/writing_plugins.html#requiring-loading-plugins-in-a-test-module-or-conftest-file - I suggest replacing
new_environment
with thetmp_env
fixture instead
I realized that a little too late. Using the |
I ended up using the |
Description
conda.testing.integration.run_command
has been deprecated. Useconda.testing.fixtures.conda_cli
instead.Checklist - did you ...
news
directory (using the template) for the next release's release notes?