Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix linting and update tests to linter friendly chai #4

Merged
merged 1 commit into from
Feb 20, 2021
Merged

Fix linting and update tests to linter friendly chai #4

merged 1 commit into from
Feb 20, 2021

Conversation

johnbeech
Copy link

@johnbeech johnbeech commented Feb 20, 2021 •
edited
Loading

  • Replace vars with lets or consts.
  • Better use of booleans to reduce inline if statements
  • Switch to using chai instead of should for assertions - friendlier to linter
  • Improved tests to be more explicit by using .deep.equals({...})

@johnbeech johnbeech merged commit 41a5635 into master Feb 20, 2021
@johnbeech johnbeech deleted the fix-linting branch February 20, 2021 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@johnbeech