Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve GitHub actions workflow warnings #1013

Closed
wants to merge 2 commits into from
Closed

Resolve GitHub actions workflow warnings #1013

wants to merge 2 commits into from

Conversation

austinvazquez
Copy link
Member

Small CI updates to run cri-o tests on Ubuntu 22.04 to resolve warnings in GitHub actions workflows.

Also updated containerd/project-checks to latest @v1 will not grab latest in this case because containerd/project-checks has v1 tag.

Signed-off by: Austin Vazquez macedonv@amazon.com

Signed-off-by: Austin Vazquez <macedonv@amazon.com>
Signed-off-by: Austin Vazquez <macedonv@amazon.com>
@ktock
Copy link
Member

ktock commented Nov 30, 2022

@austinvazquez Thank you for the patches.

cri-o tests on Ubuntu 22.04

IIRC CRI-O tests fail on ubuntu:22.04 runner because of "CRI-O in Docker" issue (discussed in #622 )
Could you separate this commit into another PR if this commit doesn't pass the CI as of now?

containerd/project-checks to latest @ v1

Thanks!

@ktock
Copy link
Member

ktock commented Nov 30, 2022

https://github.com/containerd/stargz-snapshotter/actions/runs/3585033772/jobs/6032487166#step:3:575

 #11 30.71 github.com/containerd/containerd/cmd/containerd imports
#11 30.71 	github.com/containerd/stargz-snapshotter/service/plugin imports
#11 30.71 	k8s.io/cri-api/pkg/apis/runtime/v1alpha2: package k8s.io/cri-api/pkg/apis/runtime/v1alpha2 provided by k8s.io/cri-api at latest version v0.25.4 but not at required version v0.26.0-beta.0

This will be fixed in #1011

@austinvazquez
Copy link
Member Author

austinvazquez commented Nov 30, 2022

IIRC CRI-O tests fail on ubuntu:22.04 runner because of "CRI-O in Docker" issue (discussed in #622 ) Could you separate this commit into another PR if this commit doesn't pass the CI as of now?

Thanks for the heads up @ktock . I was thinking maybe perhaps it was a runc version mismatch but that seems to not be the case. I'll close and split the commits.

@austinvazquez austinvazquez deleted the resolve-github-actions-workflow-warnings branch November 30, 2022 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants