test: do not force nftables

[Luap99]

We don't care about the driver used for out testing so just stick with the package default. I did add this only to get passing test locally back then and didn't actually intend to commit this at all.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Luap99]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Luap99]

New flake?!

not ok 10 basic container - internal network has no DNS - ipv6
# (from function `assert' in file test/helpers.bash, line 199,
#  in test file test/100-basic-name-resolution.bats, line 272)
#   `assert "$ip_a1"' failed
# /usr/sbin/dnsmasq
#  nsenter -m -n -t 2809 ip link set lo up
#  nsenter -m -n -t 2809 dnsmasq --conf-file=/var/tmp/aardvark-dns/test/dnsmasq.conf --pid-file=/tmp/aardvark_bats.bQ0RKk/dnsmasq.pid
#  nsenter -m -n -t 2809 mount --bind /tmp/aardvark_bats.bQ0RKk/resolv.conf /etc/resolv.conf
#  nsenter -m -n -t 2809 /usr/libexec/podman/netavark --config /tmp/aardvark_bats.bQ0RKk -a /var/tmp/aardvark-dns/test/../bin/aardvark-dns setup /proc/2848/ns/net
# {"podman1":{"dns_search_domains":["dns.podman"],"dns_server_ips":["fd2d:1ecf:572::1"],"interfaces":{"eth0":{"mac_address":"16:a6:b4:be:96:4f","subnets":[{"gateway":"fd2d:1ecf:572::1","ipnet":"fd2d:1ecf:572::4170/64"}]}}}}
#  nsenter -n -t 2848 dig +short aone @fd2d:1ecf:572:0::1 AAAA
# fd2d:1ecf:572::4170
# #/vvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvv
# #|     FAIL: [no test name given]
# #| expected: 'fd2d:1ecf:572:0::4170'
# #|   actual: 'fd2d:1ecf:572::4170'
# #\^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
#  nsenter -m -n -t 2809 /usr/libexec/podman/netavark --config /tmp/aardvark_bats.bQ0RKk -a /var/tmp/aardvark-dns/test/../bin/aardvark-dns teardown /proc/2848/ns/net
# 2809

How the hell is converting an ipv6 address to string not deterministic. The address is the same except for the extra :0:

[mheon]

That seems like a Golang bug, all :0: blocks can and should be removed from displayed addresses.

[mheon]

LGTM though

[Luap99]

That seems like a Golang bug, all :0: blocks can and should be removed from displayed addresses.

Look at the repo, no golang in sight :) But this is the output of dig +short not av or nv so I am even more confused...

[mheon]

Definitely a display bug, whatever tool or language it's coming from - while both addresses are correct, removing all extraneous blocks is proper to reduce display issues and the amount of space these giant 128-bit addresses take.

[baude]

/lgtm