fix: bug where preview button wouldn't show up for users #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veryspry
commented
Nov 2, 2021
| authToken, | ||
| } = this.state; | ||
|
|
||
| const validPreview = !previewUrl || isValidUrl(previewUrl); | ||
| const validContentSync = !contentSyncUrl || isValidUrl(contentSyncUrl); | ||
| const validWebhook = !webhookUrl || isValidUrl(webhookUrl); | ||
| const validPreviewWebhook = !previewWebhookUrl || isValidUrl(previewWebhookUrl); |
There was a problem hiding this comment.
As it turns out my fix in #570 was not needed and actually never added in the first place since we didn't use the value anywhere. What we really needed was to remove previewWebhookUrl altogether.
2 tasks
KyleAMathews
approved these changes
Nov 2, 2021
zcei
approved these changes
Nov 2, 2021
|
Thank you @zcei! We appreciate you helping us out 😄 |
|
Thanks for merging this after hours 😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to some confusing naming that is in place to ensure backwards compatibility for Gatsby users who have not yet moved to Content Sync preview, we accidentally introduced a regression through #569. This happened because we had references to a configuration value called
previewWebookUrlwhich was essentially unused. The correct name for the preview webhook url in the config object iswebhookUrl(this is the confusing backwards compatibility naming.)This bug is causing a missing url warning to display even if the "Preview Url" field in the config is filled out since that field is mapped to the
webhookUrland not thepreviewWebhookUrlconfig value.This PR fixes that bug and also removes references to the superfluous config item
previewWebhookUrl. @Jwhiles sorry for any confusion here and with your recent fix! I should have caught that in your PR but had already forgotten about the historical context aroundwebhookUrl(naming is important 😅) and I'm hoping that these changes help us to avoid a similar mistake in the future.