Update data validation for publisher commentActions endpoint #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iislucas
approved these changes
Jul 13, 2017
| res.json({ status: 'success' }); | ||
| next(); | ||
| } catch (e) { | ||
| console.log(e) |
There was a problem hiding this comment.
Probably wants to be a console.error? Probably you want to use the logging code...
import { logger } from '@conversationai/moderator-backend-core';
...
logger.error(e);
There was a problem hiding this comment.
Yes, good point. I'll update it.
|
@iislucas I updated the logger, so this should be good to go. |
iislucas
approved these changes
Jul 13, 2017
RufusHamade
referenced
this pull request
in RufusHamade/conversationai-moderator-1
Sep 10, 2018
* Adds drone.yml with a build step * Adds publish and deploy steps * Trigger pub/deploy from setup branch * Add google secrets * Improve deploy * Add recommended autoscaling and monitoring * Specify client build * Make npm install noisy for debugging * Temporarily diable npm install for sane build debugging * Debug publish flow * Debug publish flow * Add Dockerfile * Resilence npm install * Only 1 replica for dev * Update port * Update .app var name * Update app name to avoid collisions with existing app * Turning off dryrun... let's do this... * Update to us.grc.io * Debug * Debug image pull * Update image name * Reintroduce npm install * Removing silent from npm install to see why it is failing on drone * Reintroducing silent... it just took 28 minutes... * Update Dockerfile and port * Copy frontend-web in dockerfile * Introduce scripts from ugc-moderator * Add shared cert * Debug * Remove GAE app.yaml generator * Update drone sec * Stop using npm packages * Remove drone.bash * Remove extraneous files * Add google client id and secret placeholders * npm install backend-core deps too * Update client id dummy value so drone doesn't convert from int to string * Also npm install the config package * Try removing index to circumvent dist-commonjs require error * Return to npm package pathing * lerna install and build via drone * Lerna bootstrap, not build * Disable backend-api build script * Add healthz endpoint and configure probes * Update config to overwrite existing moderator client * Add sanity check token to prove code source * Removing sanity check token * Restore correct triggers * Add test block * Silence npm install * Debug tests block * Add prd publish and deploy * Remove tests from deploy * Update README.md * Remove npm modules & .sh pruning line * Clearer placeholder values for unused google client vars * Undo beautify formatting * More undoing of prettification * Revert, then recreate changes to undo prettify * Slaying the last of the automatic updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is a set of
/publisher/commentActions/:actionendpoints that we use to send comment decisions from CRNR to Moderator. It's basically the same as an/api/commentActions/:actionendpoints, but it was split out at some point to insulate the publisher comment flow from other Moderator API changes.Motivation and Context
When we switched from int IDs to string IDs, we updated the validation layer for the API commentActions endpoint, but not the publisher commentActions endpoint, which still requires number IDs (publisher version here vs regular api version here).
The other small change is to log errors for this endpoint. Right now they're swallowed and it makes debugging a little tricky.
How Has This Been Tested?
I manually tested it by running the backend-api locally and posting a comment to the
/publisher/commentActions/approveendpoint.Types of changes
Checklist: