Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setsockopt failed after last commit #368

Open
goldnetengineeringgroup opened this issue Jun 19, 2017 · 8 comments
Open

setsockopt failed after last commit #368

goldnetengineeringgroup opened this issue Jun 19, 2017 · 8 comments

Comments

@goldnetengineeringgroup
Copy link

last week I get last code and compile it, it works fine.
but yesterday when I get last code, I got this

chilli[1412]: removing ip address from eth1
chilli[1412]: 92 setsockopt(s=5, level=6, optname=1, optlen=4) failed
chilli[1412]: Failed to create dhcp listener on eth1

when I saw the last commit from 6 days ago and commit about setsockopt, I checked the previous commit it works fine but the last commit has the problem.
@jobezic
Copy link
Member

jobezic commented Jun 19, 2017

What about your environment?

@goldnetengineeringgroup
Copy link
Author

goldnetengineeringgroup commented Jun 19, 2017 •
edited
Loading

armbian/debian8/ubuntu 16.4/ubuntu 17
on my pc / virtual box/ orangepi nano
These days I change OS and test until I found the problem

@gbaligh
Copy link
Contributor

gbaligh commented Jun 21, 2017 •
edited
Loading

Try the pull request I just pulled : #370

@pihomeserver
Copy link

Bug confirmed on a fresh install of Raspbian Jessie Lite for Raspberry Pi
But @gbaligh you saved my day your pull request works like a charm !

@pihomeserver pihomeserver mentioned this issue Jun 22, 2017
Closed
@goldnetengineeringgroup
Copy link
Author

@gbaligh it works fine 👍

@gbaligh
Copy link
Contributor

gbaligh commented Jun 23, 2017

I have a feeling that this is not the good solution :(
In fact using this patch, the TCP_NODELAY is never set !
We must investigate more into this problem ...

@xOneca
Copy link
Contributor

xOneca commented Jun 23, 2017

So, why not just remove setsockopt() call?

@xOneca
Copy link
Contributor

xOneca commented Jun 23, 2017

The socket is always created as SOCK_RAW, and the only (commented-out) alternative is SOCK_DGRAM. Neither can have TCP_NODELAY aplied, if I'm not wrong...

gbaligh added a commit to gbaligh/coova-chilli that referenced this issue Jun 23, 2017
@gbaligh
setsockopt failed after last commit coova#368
a858eda 
Remove setsockopt() call.
The socket is always created as SOCK_RAW, and the only (commented-out)
alternative is SOCK_DGRAM. Neither can have TCP_NODELAY aplied.

Signed-off-by: Baligh GUESMI <gasmibal@gmail.com>
jobezic added a commit that referenced this issue Jun 28, 2017
@jobezic
Merge pull request #374 from gbaligh/remove_setsockopt_tcp_nodelay
19b20e3 
setsockopt failed after last commit #368
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jobezic @pihomeserver @gbaligh @xOneca @goldnetengineeringgroup