TM-45 Make detektBaseline pass #5561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dless of the existing detekt violations
zkiss
previously approved these changes
Oct 7, 2019
zkiss
reviewed
Oct 7, 2019
zkiss
reviewed
Oct 8, 2019
barrylapthorn
approved these changes
Oct 11, 2019
r3domfox
approved these changes
Oct 11, 2019
anthonykeenan
pushed a commit
that referenced
this pull request
Oct 21, 2019
* [CORDA-3304] Introduce max number of retries per invocation for reconnecting rpc * NOTICK: Fix Initiate Flow with Anonymous party (#5579) * delete buildSrc block configuring multiple plugins * remove outer stage block * fix issues around initiateFlow with anonymous party * code checks * disable unit tests * fix flowframeworktest * undo some extraneous changes * use zulu for jdk in testing image (#5583) * use zulu for jdk add some parallel groups * port kubesTest to Java remove asterix from tests listed by ListTests, instead add after allocation * Shortening lines * Add documentation and param renaming * Short git sha as docker img tag (#5586) * short git sha as docker img tag * move subSequence * CORDA-3318: fixed config property names in docs (#5589) * CORDA-3318: fixed config property names in docs * CORDA-3318: typo * disable ReturnCount detekt check (#5581) * disable ReturnCount check * rerun baseline * TM-40 Ephemeral workspace for k8s workers that survives restarts (#5567) * Simplify * Mount shared dir to worker * format * podnames with separators * refactor parameters * Use PVC for storage * pvc in namespace * KubesTest simplify * no tolowercase * no private * lowercase * RetryStrategy * minor changes * wait forever * undo .idea * elvis * add comment * regcred * use correct ConfigBuilder * delete java, will migrate later * Revert "delete java, will migrate later" This reverts commit e3bab1f * Merging changes in groovy to new java file * format * rename variable * fix log * private * remove bak * move java files * Revert "move java files" This reverts commit 89aa4c3 * TM-41 Ability to resume test runs (#5573) * TM-41 writing test completions to file to keep track of what was finished. to be used in the case that a pod terminates abruptly * TM-41 addressing PR comments * TM-41 addressing PR comments * TM-41 adding exclusion list to guard against tests being passes as a group * TM-41 trying to find the jenkins breakpoint * TM-41 debugging jenkins * TM-41 revert debugging change * TM-41 revert debugging changes * TM-41 revert debugging changes * TM-41 fixing merge conflicts * TM-41 now that TM-40 is merged static needs to be updated * TM-41 refactor constant * TM-41 fixing jenkins failure * TM-41 trying new path * TM-41 moving the file reading to the task that will be executed by the workers as the master does not have a persistent volume * TM-41 moving the after test as well * TM-45 Make detektBaseline pass (#5561) * TM-45 make the baseline generating task show a successful build regardless of the existing detekt violations * TM-45 address PR feedback * CORDA-3152: Register custom serializers for jackson as well as amqp * [CORDA-3122] - Cleanup non-finalised, errored flows (#5594) * [CORDA-3122] - Cleanup non-finalised, errored flows * detekt * [ENT-4119] Make welcome message generic * CORDA-3313 Update docs in line with DB changes. * Corda-3317 correct docs typo Removed ??? from "Note: this information is not currently supposed to be used in production." * CORDA-3313 formatting * CORDA-3257 Docker image: do not post json to filter generated zip for testnet generation (#5598) * disable pvc creation during k8s build (#5604) * disable pvc creation * make testruns available without pvc * [CORDA-3304] - Add test for max attempts on reconnecting rpc * Fix corda docker image names in docs (#5606) * CORDA-3332: Add rpc reconnection to node explorer. * TM-67 converting ImageBuilding from groovy to java (#5609) * TM-67 converting ImageBuilding from groovy to java * TM-67 wrong way to set properties * TM-67 do first does not seem to work * TM-67 setting credentials first * TM-67 small logic fix * TM-67 adding stacktrace * TM-67 addressing PR comments * TM-67 fixed normal builds that don't require docker * TM-67 adding guard rails to the code * TM-67 removing stacktrace * TM-67 addressing pr comments * CORDA-3307 - add support for environment variables in linux (#5523) * Added a new way for environment variables to be loaded, which allows for underscore based separation. * Moved test to its own kotlin file. * Added case insensitivity support. * The corda. prefix is now case insensitive too. * Removed unused variable. * Added env variables support for driverDSL. Shadowing corda. properties raises an exception. * Driver api stability fix. * Changed type of cordapps param to reflect the real one, rather than what IntelliJ auto completed. * Some detekt issue fixes. Spread operator removed, baselined api stability constructors and buggy line. * Fixed misspelled variable. * Reverted unintentional changes. * Added suppress instead of changing baseline. * Reworked logic to handle previously defined CORDA_ starting properties and handle accordingly. Fixed a bug where wrong class was used for reflection walking. * Fix for detekt issues. * Changed message to a more understandable one. * Changelog + doc note, console error grammar. * Changes according to PR review. * [CORDA-3342] - Show proper error message and adjust indentation in shell (#5612) * CORDA-3336: Remove log4j plugins to stop errors in config generator (#5617)
chrisr3
pushed a commit
that referenced
this pull request
Oct 21, 2019
* TM-45 make the baseline generating task show a successful build regardless of the existing detekt violations * TM-45 address PR feedback
chrisr3
pushed a commit
that referenced
this pull request
Oct 21, 2019
* TM-45 make the baseline generating task show a successful build regardless of the existing detekt violations * TM-45 address PR feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The task detektBaseline would always fail because when generating the baseline, the existing one will not be taken into account so existing violations will flare up and fail the build. Fixed by introducing a second config with a high threshold number to force detekt to stay quiet and return a successful build since returning a failure can be misleading. Tried to find a less hackier solution but no luck. Unless we fork detekt and build it ourselves, so this will have to do