INFRA-505: Move integration tests to unit tests

[yift-r3]

Move two integration tests to a few unit tests.

[rekalov]

Thank you, looks good.

[rekalov]

I have one more thing, sorry for chaotic comments.

Newly added fine-gran tests and small re-factoring are fine. But how do we conceptually make sure that initKeyStores() is properly called on the node start after removal of integration tests?

@rnicoll , what do you think?

[rekalov]

BootTests looks reasonable substitution for removed integration tests. So, OK.

[rnicoll]

So it's a two part answer here; on the one hand, I think the dozens of tests which spin up full nodes then interact with their node info will cover this.

The other part, however, is that I would look to unit tests to stop accidental errors creeping in, rather than model how the code is written currently. Having a unit test for initKeyStores() (if we don't elsewhere) would be good, but I'd consider it unlikely someone would accidentally cut the call to initKeyStores() out later, and it's low value to test for.