plugin/kubernetes: Return all records with matching IP for PTR requests #3687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris O'Haver <cohaver@infoblox.com>
chrisohaver
requested review from
bradbeam,
johnbelamaric,
miekg,
rajansandeep and
yongtang
as code owners
bradbeam
approved these changes
Feb 20, 2020
Codecov Report
@@ Coverage Diff @@
## master #3687 +/- ##
==========================================
+ Coverage 56.65% 56.67% +0.01%
==========================================
Files 220 220
Lines 11059 11060 +1
==========================================
+ Hits 6266 6268 +2
+ Misses 4311 4310 -1
Partials 482 482
Continue to review full report at Codecov.
|
nyodas
pushed a commit
to DataDog/coredns
that referenced
this pull request
Oct 26, 2020
Signed-off-by: Chris O'Haver <cohaver@infoblox.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Why is this pull request needed and what does it do?
For PTR requests of an Endpoint that has two or more Services pointed to it, provide an answer for each Service. Previously, we were arbitrarily selecting the first one encountered (based on ordering in the index).
2. Which issues (if any) are related?
#3686
3. Which documentation changes (if any) need to be made?
none
4. Does this introduce a backward incompatible change or deprecation?
no