Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[next-devel] Add platform-specific console configuration metadata #1781

Merged
merged 1 commit into from
Sep 19, 2022
Merged

[next-devel] Add platform-specific console configuration metadata #1781

merged 1 commit into from
Sep 19, 2022

Conversation

bgilbert
Copy link
Contributor

@bgilbert bgilbert commented Jun 9, 2022 •
edited
Loading

coreos-assembler create_disk.sh and gf-set-platform will read this. create_disk.sh will also save a JSON version for the relevant architecture to /boot/coreos/platforms.json for coreos-installer.

Continuation of #1181.

@github-actions
Copy link

github-actions bot commented Jun 9, 2022

⛔ The next-devel branch is currently closed. PRs should target only testing-devel.

@bgilbert bgilbert mentioned this pull request Jun 9, 2022
Closed
@github-actions
Copy link

github-actions bot commented Jun 9, 2022

⛔ The next-devel branch is currently closed. PRs should target only testing-devel.

@bgilbert bgilbert marked this pull request as draft June 9, 2022 23:38
@dustymabe
Copy link
Member

We could go ahead and get this in rawhide now if we wanted some advance testing.

@github-actions
Copy link

⛔ The next-devel branch is currently closed. PRs should target only testing-devel.

This was referenced Jun 22, 2022
Closed
Closed
@bgilbert bgilbert mentioned this pull request Sep 13, 2022
Merged
@bgilbert
Copy link
Contributor Author

Rebased. Moved tests to #1974. Re-added graphical consoles to AWS, Azure, and GCP on x86_64, since those platforms allow taking screenshots of the graphical console to diagnose the VM.

@dustymabe
Copy link
Member

We've got the major cloud platforms covered here. Any other ones we think we need to add?

@bgilbert
Copy link
Contributor Author

I've rechecked all of the FCOS platforms against any documentation provided by the platform provider. The ibmcloud serial console apparently slipped through last time, so I've now added that.

@bgilbert
Add platform-specific console configuration metadata
afd3d43 
cosa create_disk.sh and gf-set-platform will read this.  create_disk.sh
will also save a JSON version for the relevant architecture to
/boot/coreos/platforms.json for coreos-installer.

Enable graphical console on cloud platforms that allow capturing
screenshots, even if the graphical console is not interactive.
@dustymabe
Copy link
Member

any sane defaults we could use for openstack?

@bgilbert
Copy link
Contributor Author

We're using them. OpenStack can support both graphical and serial console, but graphical console appears to be the one that's emphasized by the UI.

@bgilbert bgilbert mentioned this pull request Sep 14, 2022
Merged
@bgilbert bgilbert marked this pull request as ready for review September 19, 2022 21:28
@bgilbert bgilbert merged commit 019caed into coreos:next-devel Sep 19, 2022
@bgilbert bgilbert deleted the platforms/next-devel branch September 19, 2022 21:32
@bgilbert bgilbert mentioned this pull request Nov 1, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dustymabe dustymabe dustymabe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bgilbert @dustymabe