postprocess: Add a symlink /usr/lib/sysimage/rpm to the rpmdb #2154
Conversation
|
@cgwalters Why can't we do a hard swap and have the symlink in the legacy location? |
|
It's a much more invasive patch requiring changing at least the The goal here is for projects like libsolv to be able to consistently find the db at the new location, and the symlink solves that. But if you want to dive into the code and do the bigger change, feel free! |
src/libpriv/rpmostree-core.h
Outdated
| @@ -35,6 +35,7 @@ | |||
| /* See http://lists.rpm.org/pipermail/rpm-maint/2017-October/006681.html */ | |||
| #define RPMOSTREE_RPMDB_LOCATION "usr/share/rpm" | |||
| #define RPMOSTREE_SYSIMAGE_DIR "usr/lib/sysimage" | |||
| #define RPMOSTREE_NEW_RPMDB_LOCATION RPMOSTREE_SYSIMAGE_DIR "/rpm" | |||
There was a problem hiding this comment.
The funny thing with NEW is that it quickly becomes outdated. :) How about just e.g. RPMOSTREE_SYSIMAGE_RPMDB_LOCATION?
Following on to: - http://lists.rpm.org/pipermail/rpm-maint/2017-October/006681.html - coreos#1142 - openSUSE/libsolv#386 Write a symlink in `/usr/lib/sysimage/rpm` pointing to our current `/usr/share/rpm` - this way clients can start looking for it there, and then at some point we'll flip the symlink around and have `/usr/share/rpm` pointing to the new location. (Doing a hard swap now has upgrade implications)
cgwalters
force-pushed
the
symlink-sysimage
branch
from
f501918 to
2aaae02
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashcrow, cgwalters, Conan-Kudo, jlebon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Looks like a CI timeout |
Following on to:
Write a symlink in
/usr/lib/sysimage/rpmpointing to our current/usr/share/rpm- this way clients can start looking for it there,and then at some point we'll flip the symlink around and
have
/usr/share/rpmpointing to the new location.(Doing a hard swap now has upgrade implications)