composepost: Remove /usr/lib/sysimage/rpm dir before symlinking #3399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rawhide has moved the rpmdb to `/usr/lib/sysimage/rpm`, which is great! FCOS composes started breaking because rpm now creates that directory: coreos#3397 We should be able to eventually flip our `_dbpath` macro with this (and eventually much later once it hits RHEL, stop overriding the macro at all). This will require some careful changes and testing. But anyway we probably don't want to do this yet on f35 to match Fedora, so we will want a transition mechanism; e.g. a `rpmdb-in-sysimage` treefile knob. For now just to unblock rawhide changes, let's remove the empty dir so we can symlink and keep `/usr/share/rpm` as canonical. We'll rework once we have the permanent solution.
|
CI won't test Anyway, I did verify this unbreaks rawhide composes and that at least |
cgwalters
approved these changes
Feb 3, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rawhide has moved the rpmdb to
/usr/lib/sysimage/rpm, which is great!FCOS composes started breaking because rpm now creates that directory:
#3397
We should be able to eventually flip our
_dbpathmacro with this (andeventually much later once it hits RHEL, stop overriding the macro at
all). This will require some careful changes and testing.
But anyway we probably don't want to do this yet on f35 to match Fedora,
so we will want a transition mechanism; e.g. a
rpmdb-in-sysimagetreefile knob.
For now just to unblock rawhide changes, let's remove the empty dir so
we can symlink and keep
/usr/share/rpmas canonical. We'll rework oncewe have the permanent solution.