Skip to content

Commit

Permalink
Merge pull request #2043 from dpfaffenbauer/pimcore10-5-tests
Browse files Browse the repository at this point in the history
[Pimcore] add tests for ^10.5
  • Loading branch information
dpfaffenbauer authored Jul 21, 2022
2 parents 921e0fb + 5b20279 commit 2a8b6d4
Show file tree
Hide file tree
Showing 8 changed files with 17 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/behat.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
strategy:
matrix:
php: [ 8.0, 8.1 ]
pimcore: [ ^10.4, 10.x-dev ]
pimcore: [ ^10.4, ^10.5 ]
dependencies: [ highest, lowest ]
exclude:
- php: 8.1
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/behat_ui.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
strategy:
matrix:
php: [ 8.0, 8.1 ]
pimcore: [ ^10.4, 10.x-dev ]
pimcore: [ ^10.4, ^10.5 ]
dependencies: [ highest, lowest ]
exclude:
- php: 8.1
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/packages_bundles.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
fail-fast: false
matrix:
php: [ 8.0, 8.1 ]
pimcore: [ ^10.4, 10.x-dev ]
pimcore: [ ^10.4, ^10.5 ]
dependencies: [ highest, lowest ]
package: "${{ fromJson(needs.list.outputs.packages) }}"
exclude:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/packages_components.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
fail-fast: false
matrix:
php: [ 8.0, 8.1 ]
pimcore: [ ^10.4, 10.x-dev ]
pimcore: [ ^10.4, ^10.5 ]
dependencies: [ highest, lowest ]
package: "${{ fromJson(needs.list.outputs.packages) }}"
exclude:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/static.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
strategy:
matrix:
php: [ 8.0, 8.1 ]
pimcore: [ ^10.4, 10.x-dev ]
pimcore: [ ^10.4, ^10.5 ]
dependencies: [ highest, lowest ]
exclude:
- php: 8.1
Expand Down
3 changes: 3 additions & 0 deletions src/CoreShop/Behat/Service/Tracking/ConfigResolver.php
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ class ConfigResolver implements ConfigResolverInterface
{
public function getGoogleConfig(): ConfigObject
{
/**
* @psalm-suppress DeprecatedClass
*/
return new ConfigObject([]);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,18 @@

class ConfigResolver implements ConfigResolverInterface
{
/**
* @psalm-suppress DeprecatedClass
*/
private ?ConfigObject $googleConfig;

public function __construct(private SiteIdProvider $siteIdProvider, private GoogleConfigProvider $goggleConfigProvider)
{
}

/**
* @psalm-suppress DeprecatedClass
*/
public function getGoogleConfig(): ?ConfigObject
{
if (isset($this->googleConfig)) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,8 @@

interface ConfigResolverInterface
{
/**
* @psalm-suppress DeprecatedClass
*/
public function getGoogleConfig(): ?ConfigObject;
}

0 comments on commit 2a8b6d4

Please sign in to comment.