[CoreExtensions] refactor how Doctrine Entities are cloned #1770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… clone anymore, as it is way to unpredictable in some matters. Use a CustomCopy from Pimcore and manually clone and reset data.
jdreesen
reviewed
Nov 4, 2021
src/CoreShop/Component/Pimcore/BCLayer/CustomDataCopyInterface.php
Outdated
Show resolved
Hide resolved
|
ping @solverat |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't use
__cloneanymore, as it is way too unpredictable in some matters. Use aCustomCopyfrom Pimcore and manually clone and reset data. This also doesn't completely clone all the data, since we have some dependencies from store-values to Product Unit Definitions. But this is something we cannot solve this way and therefore is simply just not supported. This also fixes copying of Specific Product Price Rules and Quantity Price Rules.<!-