-
-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wishlist #2030
Wishlist #2030
Conversation
Looking at the PR, it's very nice progress. I think the direction is good, but since the change set is so large, it seems to me there's a lot of similarities with Cart that we should be able to reuse more code maybe? For example, let's say we introduce a "product comparison" feature in the future, it would also be a list of products which you can add/remove to a separate storage, it would seem wasteful to need to again add so much functionality. With this in mind, is there anything we could do to abstract code for better reuse here? |
@dkarlovi Absolutely! The plan was to first create the wishlist and check what we need, and then further refactor and abstract it. Stuff could move into the StorageList Component and maybe we also have to create a StorageListBundle to abstract and combine stuff. But I am looking into that |
@dkarlovi reworked a lot now to share more between Order and Wishlist, you might wanna check? |
thanks @IvanJavorovic for kicking this off |
WIP new Wishlist bundle added to replace existing wishlist functionality. Review and changes are needed.