Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reports] Support filtering for order type #2055

Merged

Conversation

BlackbitDevs
Copy link
Contributor

This PR adds an order type filter to the products, category and manufacturer reports because for reporting it is sometimes necessary to show all orders, not only the completed ones.

Additionally with this PR the category report supports maintaining product-category relation on category side (many-to-many object relation in Category class with allowed class Product).
And the manufacturer report now also supports the name field to be localized.

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no

support maintaining product-category relation in category side
support localized field "name" for manufacturer report
…der-state-filter

# Conflicts:
#	src/CoreShop/Bundle/CoreBundle/Report/CategoriesReport.php
#	src/CoreShop/Bundle/CoreBundle/Report/ManufacturerReport.php
#	src/CoreShop/Bundle/CoreBundle/Report/ProductsReport.php
support maintaining product-category relation in category side
support localized field "name" for manufacturer report
@dpfaffenbauer
Copy link
Member

@BlackbitNeueMedien I think it would be good if we use all available states and not statically implement them in Frontend. States are adjustable and can be altered per Project.

You already have the states in ExtJs as DataStore, you just either need to add the "all" field or allow the Filter to be empty to get all states. The Store is accessible with pimcore.globalmanager.get('coreshop_states_order')

@BlackbitDevs
Copy link
Contributor Author

Thanks. Have applied the suggested changes. I removed the all option because setting no value means all items everywhere in Pimcore, so it can be the same here.

@dpfaffenbauer dpfaffenbauer merged commit 6b2acc1 into coreshop:master Aug 29, 2022
@dpfaffenbauer
Copy link
Member

thanks @BlackbitNeueMedien

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants