-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Advanced Stats Functionality (#96) #101
base: main
Are you sure you want to change the base?
Conversation
Thanks for this! I'll be away until 2/23, so I don't think I can give this a full review before then, but I will try. |
So this is introducing design patterns that are separate from the core API library, almost as if they are separate utilities. Do you think there is a way to incorporate this into the current design structure, for something like: client.advanced_stats.goalie_stats() I can see the difficulty in running asynchronous web sockets to load this, but having it incorporated into the current library design would be beneficial for end users. Depending on difficulty, could do some kind of utilities options, where it can be installed as an optional package include. |
This PR introduces advanced stats functionality to the NHL API. It addresses issue #96 by adding new modules and examples.
Testing Instructions:
I welcome any feedback or suggestions for further refinement.