config upgrade: remove redundant test cases (GoogleContainerTools#1585)

Signed-off-by: Cornelius Weig <cornelius.weig@tngtech.com>
corneliusweig · Mar 10, 2019 · 67d8fe1 · 67d8fe1
1 parent 08572a9
commit 67d8fe1
Show file tree

Hide file tree

Showing 7 changed files with 0 additions and 182 deletions.
diff --git a/pkg/skaffold/schema/v1alpha3/upgrade_test.go b/pkg/skaffold/schema/v1alpha3/upgrade_test.go
@@ -101,32 +101,6 @@ profiles:
 	verifyUpgrade(t, yaml, expected)
 }
 
-func TestUpgrade_helmReleaseOverrides(t *testing.T) {
-	yaml := `apiVersion: skaffold/v1alpha3
-kind: Config
-deploy:
-  helm:
-    releases:
-    - name: test release
-      overrides:
-        global:
-          localstack:
-            enabled: true
-`
-	expected := `apiVersion: skaffold/v1alpha4
-kind: Config
-deploy:
-  helm:
-    releases:
-    - name: test release
-      overrides:
-        global:
-          localstack:
-            enabled: true
-`
-	verifyUpgrade(t, yaml, expected)
-}
-
 func verifyUpgrade(t *testing.T, input, output string) {
 	pipeline := NewSkaffoldPipeline()
 	err := yaml.UnmarshalStrict([]byte(input), pipeline)

diff --git a/pkg/skaffold/schema/v1alpha4/upgrade_test.go b/pkg/skaffold/schema/v1alpha4/upgrade_test.go
@@ -83,32 +83,6 @@ profiles:
 	verifyUpgrade(t, yaml, expected)
 }
 
-func TestUpgrade_helmReleaseOverrides(t *testing.T) {
-	yaml := `apiVersion: skaffold/v1alpha4
-kind: Config
-deploy:
-  helm:
-    releases:
-    - name: test release
-      overrides:
-        global:
-          localstack:
-            enabled: true
-`
-	expected := `apiVersion: skaffold/v1alpha5
-kind: Config
-deploy:
-  helm:
-    releases:
-    - name: test release
-      overrides:
-        global:
-          localstack:
-            enabled: true
-`
-	verifyUpgrade(t, yaml, expected)
-}
-
 func verifyUpgrade(t *testing.T, input, output string) {
 	pipeline := NewSkaffoldPipeline()
 	err := yaml.UnmarshalStrict([]byte(input), pipeline)

diff --git a/pkg/skaffold/schema/v1alpha5/upgrade_test.go b/pkg/skaffold/schema/v1alpha5/upgrade_test.go
@@ -115,32 +115,6 @@ profiles:
 	verifyUpgrade(t, yaml, expected)
 }
 
-func TestUpgrade_helmReleaseOverrides(t *testing.T) {
-	yaml := `apiVersion: skaffold/v1alpha5
-kind: Config
-deploy:
-  helm:
-    releases:
-    - name: test release
-      overrides:
-        global:
-          localstack:
-            enabled: true
-`
-	expected := `apiVersion: skaffold/v1beta1
-kind: Config
-deploy:
-  helm:
-    releases:
-    - name: test release
-      overrides:
-        global:
-          localstack:
-            enabled: true
-`
-	verifyUpgrade(t, yaml, expected)
-}
-
 func upgradeShouldFailt(t *testing.T, input string) {
 	pipeline := NewSkaffoldPipeline()
 	err := yaml.UnmarshalStrict([]byte(input), pipeline)

diff --git a/pkg/skaffold/schema/v1beta1/upgrade_test.go b/pkg/skaffold/schema/v1beta1/upgrade_test.go
@@ -96,32 +96,6 @@ profiles:
 	verifyUpgrade(t, yaml, expected)
 }
 
-func TestUpgrade_helmReleaseOverrides(t *testing.T) {
-	yaml := `apiVersion: skaffold/v1beta1
-kind: Config
-deploy:
-  helm:
-    releases:
-    - name: test release
-      overrides:
-        global:
-          localstack:
-            enabled: true
-`
-	expected := `apiVersion: skaffold/v1beta2
-kind: Config
-deploy:
-  helm:
-    releases:
-    - name: test release
-      overrides:
-        global:
-          localstack:
-            enabled: true
-`
-	verifyUpgrade(t, yaml, expected)
-}
-
 func verifyUpgrade(t *testing.T, input, output string) {
 	pipeline := NewSkaffoldPipeline()
 	err := yaml.UnmarshalStrict([]byte(input), pipeline)

diff --git a/pkg/skaffold/schema/v1beta2/upgrade_test.go b/pkg/skaffold/schema/v1beta2/upgrade_test.go
@@ -94,32 +94,6 @@ profiles:
 	verifyUpgrade(t, yaml, expected)
 }
 
-func TestUpgrade_helmReleaseOverrides(t *testing.T) {
-	yaml := `apiVersion: skaffold/v1beta2
-kind: Config
-deploy:
-  helm:
-    releases:
-    - name: test release
-      overrides:
-        global:
-          localstack:
-            enabled: true
-`
-	expected := `apiVersion: skaffold/v1beta3
-kind: Config
-deploy:
-  helm:
-    releases:
-    - name: test release
-      overrides:
-        global:
-          localstack:
-            enabled: true
-`
-	verifyUpgrade(t, yaml, expected)
-}
-
 func verifyUpgrade(t *testing.T, input, output string) {
 	pipeline := NewSkaffoldPipeline()
 	err := yaml.UnmarshalStrict([]byte(input), pipeline)

diff --git a/pkg/skaffold/schema/v1beta3/upgrade_test.go b/pkg/skaffold/schema/v1beta3/upgrade_test.go
@@ -94,32 +94,6 @@ profiles:
 	verifyUpgrade(t, yaml, expected)
 }
 
-func TestUpgrade_helmReleaseOverrides(t *testing.T) {
-	yaml := `apiVersion: skaffold/v1beta3
-kind: Config
-deploy:
-  helm:
-    releases:
-    - name: test release
-      overrides:
-        global:
-          localstack:
-            enabled: true
-`
-	expected := `apiVersion: skaffold/v1beta4
-kind: Config
-deploy:
-  helm:
-    releases:
-    - name: test release
-      overrides:
-        global:
-          localstack:
-            enabled: true
-`
-	verifyUpgrade(t, yaml, expected)
-}
-
 func verifyUpgrade(t *testing.T, input, output string) {
 	pipeline := NewSkaffoldPipeline()
 	err := yaml.UnmarshalStrict([]byte(input), pipeline)

diff --git a/pkg/skaffold/schema/v1beta4/upgrade_test.go b/pkg/skaffold/schema/v1beta4/upgrade_test.go
@@ -94,32 +94,6 @@ profiles:
 	verifyUpgrade(t, yaml, expected)
 }
 
-func TestUpgrade_helmReleaseOverrides(t *testing.T) {
-	yaml := `apiVersion: skaffold/v1beta4
-kind: Config
-deploy:
-  helm:
-    releases:
-    - name: test release
-      overrides:
-        global:
-          localstack:
-            enabled: true
-`
-	expected := `apiVersion: skaffold/v1beta5
-kind: Config
-deploy:
-  helm:
-    releases:
-    - name: test release
-      overrides:
-        global:
-          localstack:
-            enabled: true
-`
-	verifyUpgrade(t, yaml, expected)
-}
-
 func verifyUpgrade(t *testing.T, input, output string) {
 	pipeline := NewSkaffoldPipeline()
 	err := yaml.UnmarshalStrict([]byte(input), pipeline)