-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add core module with app config support #11914
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks solid!
gopkg.in/yaml.v2 v2.4.0 // indirect | ||
) | ||
|
||
replace github.com/cosmos/cosmos-sdk/api => ../api |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we'll update this once we update the api module vanity URL and tag it.
Codecov Report
@@ Coverage Diff @@
## main #11914 +/- ##
==========================================
- Coverage 66.30% 66.04% -0.26%
==========================================
Files 689 676 -13
Lines 72303 71346 -957
==========================================
- Hits 47943 47124 -819
+ Misses 21635 21538 -97
+ Partials 2725 2684 -41 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!!
Description
Ref: #11899
This initializes app wiring officially in the SDK by adding the
cosmossdk.io/core
go module with two packages:appmodule
for registering module implementationsappconfig
for loading declarative app configsAuthor Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change