-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Insecure Script / Content Execution and BigInt not working properly #1443
Conversation
Signed-off-by: Sebastian Ko <sebastian93921@gmail.com>
Signed-off-by: Sebastian Ko <sebastian93921@gmail.com>
Signed-off-by: Sebastian Ko <sebastian93921@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix TypeError: Do not know how to serialize a BigInt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bugfix on BigInt based on the following:
paulmillr/noble-ed25519#23
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/electron-builder@23.2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much appreciated your work! @sebastian93921
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
dev
?yarn build
)yarn test
)yarn lint:js
)yarn audit
)Thank you for your code, it's appreciated! :)