Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Insecure Script / Content Execution and BigInt not working properly #1443

Merged
merged 6 commits into from
Jul 4, 2024

Conversation

sebastian93921
Copy link
Contributor

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Have you rebased your work on top of the latest dev?
  • Does your PR follow the Conventional Commits Guide?
  • Have you checked your code compiles? (yarn build)
  • Have you included tests for any non-trivial functionality?
  • Have you followed the Multi-Language Content Management Guide?
  • Have you checked your code passes the unit tests? (yarn test)
  • Have you checked your code formatting is correct? (yarn lint:js)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (yarn audit)
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Signed-off-by: Sebastian Ko <sebastian93921@gmail.com>
@sebastian93921 sebastian93921 requested a review from a team as a code owner July 3, 2024 05:44
Signed-off-by: Sebastian Ko <sebastian93921@gmail.com>
Signed-off-by: Sebastian Ko <sebastian93921@gmail.com>
Copy link
Contributor Author

@sebastian93921 sebastian93921 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix TypeError: Do not know how to serialize a BigInt

Copy link
Contributor Author

@sebastian93921 sebastian93921 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bugfix on BigInt based on the following:
paulmillr/noble-ed25519#23

@sebastian93921 sebastian93921 changed the title Fix Insecure Script / Content Execution Fix Insecure Script / Content Execution and BigInt not working properly Jul 4, 2024
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/async@3.2.5 None 0 808 kB aearly
npm/braces@3.0.3 None +3 93.9 kB jonschlinkert
npm/electron-builder@24.13.2 Transitive: environment, eval, filesystem, network, shell +115 151 MB onegoldfishh
npm/https-proxy-agent@5.0.1 network +1 60.6 kB tootallnate
npm/minipass@7.1.2 None 0 286 kB isaacs
npm/ws@8.17.1 environment, network Transitive: filesystem +3 757 kB lpinca

🚮 Removed packages: npm/electron-builder@23.2.0

View full report↗︎

Copy link
Collaborator

@crypto-matto crypto-matto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much appreciated your work! @sebastian93921

Copy link
Collaborator

@XinyuCRO XinyuCRO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crypto-matto crypto-matto merged commit 6da2c34 into crypto-com:dev Jul 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants