Adding option to skip loading models from subdirectories #767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nard-tech
reviewed
Feb 29, 2020
|
@ethanbresler I apologize for the delay in reviewing. Thanks for this patch. Would it be possible to add tests for this? |
@drwl Added tests, but the CI tests are failing due to an 'install sql lite' error. Is this something on my end or a problem with the integration tests? |
|
@drwl can we get another review of this? thanks! |
|
@maxh I apologize for the delay. @ethanbresler can you try rebasing? I believe that should be fixed. |
Changing `present?` use to be cleaner Co-Authored-By: Shu Fujita <s.fujita@nard.tech>
|
@drwl any updates here? Can I get this merged? Thanks so much! |
drwl
approved these changes
May 8, 2020
ocarta-l
pushed a commit
to ocarta-l/annotate_models
that referenced
this pull request
Jun 18, 2021
Currently, the models annotator automatically attempts to find a class with a matching name at the bottom of project's directory tree before going up into specific engine's models. This causes issues with models that share names with classes in other engines or lower classes in the project's directory. This PR adds the option to skip attempts to load classes from lower directories and just uses the model's file path directly. ctran#674
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the models annotator automatically attempts to find a class with a matching name at the bottom of project's directory tree before going up into specific engine's models. This causes issues with models that share names with classes in other engines or lower classes in the project's directory. This PR adds the option to skip attempts to load classes from lower directories and just uses the model's file path directly.
#674
cc @maxh