[Junit] update to Gherkin5. -- review nit picks

[mpkorstanje]

No description provided.

[mattwynne]

@aslakhellesoy and I tried to review this today but found some failing tests in the pretty formatter.

We realised that for some reason, travis hasn't built this branch. Can you try pushing to it again (you could use git commit --allow-empty) and see if it triggers a build? Do all the tests definitely pass for you locally?

[mpkorstanje]

You guys are moving a bit faster then expected! The review process was not nearly as linear as it appears here.

[aslakhellesoy]

You're just used to our snail pace :-) We're doing what we can to be more regularly involved and more responsive!

[mpkorstanje]

Build is passing locally.

I'm thinking travis is not picking this up because this is not a PR against master but against use-gherkin4.

[mattwynne]

Aha, yeah. Since that branch has now been merged you might need to open a new PR.

[mpkorstanje]

No problem. Need to start working against cucumber-jvm repo anyway.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.