[Spring] Do not share ContextCache between threads #1153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpkorstanje
force-pushed
the
fix-spring-factory
branch
2 times, most recently
from
0010b4c to
a155490
Compare
The TestContextManager(Class<?>) uses a static ContextCache. This meant that step definitions from different threads could be registered in same context multiple times when running in parallel. This is resolved by creating a ThreadLocal ContextCache for each SpringFactory. Related issues: - https://travis-ci.org/cucumber/cucumber-jvm/jobs/244215644 - #1148
mpkorstanje
force-pushed
the
fix-spring-factory
branch
from
a155490 to
6eece8d
Compare
|
I merged this one a bit earlier then I'd liked. Spring kept failing the build otherwise. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
TestContextManager(Class<?>)uses a static ContextCache. This meantthat step definitions from different threads could be registered in
same context multiple times when running in parallel.
This is resolved by creating a ThreadLocal ContextCache for each
SpringFactory.
Related issues: