[Core] Add the SnippetsSuggestedEvent. #1163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the SnippetsSuggestedEvent and remove the snippets from the undefined results.
brasmusson
force-pushed
the
add-snippets-suggested-event
branch
from
117dd17 to
94ae6cf
Compare
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add the SnippetsSuggestedEvent and remove the snippets from the undefined results.
Details
Generate the snippets directly when not match is found for a step and communication them in a separate event, instead of pass them on the result object with the TestStepFinished event.
Motivation and Context
Better separation of concerns.
How Has This Been Tested?
The automated test suite is updated to verify this behaviour.
Types of changes
Checklist: